Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nord theme markdown syntax needs improvement #3236

Closed
pr3c0g opened this issue May 20, 2020 · 3 comments
Closed

Nord theme markdown syntax needs improvement #3236

pr3c0g opened this issue May 20, 2020 · 3 comments
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@pr3c0g
Copy link

pr3c0g commented May 20, 2020

After the last update the markdown syntax highlighting for the Nord theme had some colors changed.

This is relevant only for the code editor, the preview is working fine.

This is how it looks at the moment:
image

Environment

Joplin version: Joplin 1.0.211 (prod, darwin)
Platform: Mac OS

Steps to reproduce

  1. On settings, change the theme to "Nord"
  2. Create new note
  3. Type markdown syntax on the code editor and check the syntax highlight

Describe what you expected to happen

This is how it should look, based on the Nord theme applied on other text editors

VSCode:
image

SublimeText:
image

Thank you so much for your hard work!

@pr3c0g pr3c0g added the bug It's a bug label May 20, 2020
@shbach
Copy link

shbach commented May 25, 2020

I just created #3269 before noticing yours. Mine reports issues with all the themes and it encompasses this though you have more detail on the Nord theme.

@stale
Copy link

stale bot commented Jul 9, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Jul 9, 2020
@stale
Copy link

stale bot commented Jul 16, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

2 participants