Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code View toggle (going back from the WYSIWYG editor) breaks images #3267

Closed
alfredbaudisch opened this issue May 24, 2020 · 2 comments
Closed
Labels
bug It's a bug desktop All desktop platforms high High priority issues

Comments

@alfredbaudisch
Copy link

alfredbaudisch commented May 24, 2020

The WYSIWYG editor breaks all existing images from a Markdown note. It adds the full local path to images previously added through Markdown.

For example, the image was 63545214c69fcaff3f19afd2b0e0e651 and correctly placed with Markdown, when going to WYSIWYG, it changed to a full local path. It is possible to see the change in the attached log.

!\[63545214c69fcaff3f19afd2b0e0e651.png\]([file://C:/Users/1545](file://C:/Users/1545) IRON
 V4/.config/joplin-desktop/resources/40270689124e42cbb6ac2fddbcf621d8.png)

image

Environment

Joplin 1.0.216 (prod, win32)

Client ID: 88172fdc238748cabba691cc30d18a14
Sync Version: 1
Profile Version: 29

Revision: 4eb680d (master)

Windows 10

Steps to reproduce

  1. Create a note in the default Markdown editor or open an existing note
  2. Add an image.
  3. Now switch to the WYSIWYG editor by using the new "Code View" button from the top bar
  4. Make any kind of change in the node (which is not related to the images). For example, add a new character somehwere.
  5. Now switch back to the default editor by clicking "Code View" again
  6. Images are now broken.

Describe what you expected to happen

Do not break the images when going to WYSIWYG and back, i.e. keep as relative path:

![5ed17f4f1a544e592751dbd18d5d3e1e.png](:/6b1f0d790184435586ffbf5e4fce9e1a)

Logfile

debug.log

@alfredbaudisch alfredbaudisch added the bug It's a bug label May 24, 2020
@laurent22
Copy link
Owner

Is that the portable version?

@laurent22 laurent22 added desktop All desktop platforms high High priority issues labels May 24, 2020
@alfredbaudisch
Copy link
Author

alfredbaudisch commented May 25, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms high High priority issues
Projects
None yet
Development

No branches or pull requests

2 participants