Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goto Anything doesn't work when typing Chinese #3153

Closed
ylc395 opened this issue Apr 30, 2020 · 3 comments · Fixed by #3180
Closed

Goto Anything doesn't work when typing Chinese #3153

ylc395 opened this issue Apr 30, 2020 · 3 comments · Fixed by #3180
Labels
bug It's a bug

Comments

@ylc395
Copy link
Contributor

ylc395 commented Apr 30, 2020

Environment

Joplin version: 1.0.201
Platform: macOS
OS specifics: 10.15.4

Steps to reproduce

  1. Type some Chinese characters in Goto Anything
  2. Nothing show up even if delete Chinese characters and type some English characters util reopen Goto Anything

Describe what you expected to happen

Goto Anything can work with non-English characters

Logfile

/Applications/Joplin.app/Contents/Resources/app.asar/plugins/GotoAnything.min.js:215 Uncaught (in promise) TypeError: Cannot read property 'includes' of undefined
    at /Applications/Joplin.app/Contents/Resources/app.asar/plugins/GotoAnything.min.js:215
    at Array.find (<anonymous>)
    at Dialog.updateList (/Applications/Joplin.app/Contents/Resources/app.asar/plugins/GotoAnything.min.js:215)
    at processTicksAndRejections (internal/process/task_queues.js:85)
    at async /Applications/Joplin.app/Contents/Resources/app.asar/plugins/GotoAnything.min.js:160

This issue is maybe related to #3093

@ylc395 ylc395 added the bug It's a bug label Apr 30, 2020
@Rahulm2310
Copy link
Contributor

@ylc395 I checked it. Goto Anything is perfectly working with arabic, cyrillicand hindi . So it is not about all non-english characters. But yeah, there is issue with chinese

@ylc395
Copy link
Contributor Author

ylc395 commented Apr 30, 2020

@Rahulm2310 I've been checked out the source code. While searching with ja, zh, ko, th, the SearchEngine will return a basic search result instead of a standard search result, and this breaks the code

@qiao-wei
Copy link

qiao-wei commented May 4, 2020

the same .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants