Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attaching an image or a file to a new empty note puts markdown tag into the title #2915

Closed
roman-r-m opened this issue Mar 26, 2020 · 10 comments · Fixed by #2955
Closed

Attaching an image or a file to a new empty note puts markdown tag into the title #2915

roman-r-m opened this issue Mar 26, 2020 · 10 comments · Fixed by #2955
Labels
bug It's a bug

Comments

@roman-r-m
Copy link
Collaborator

Steps to reproduce:

  1. Create a new empty note
  2. Attach any file or image
  3. Save the note

Maybe set the title from the file name instead or just "Untitled"?

@roman-r-m roman-r-m added the bug It's a bug label Mar 26, 2020
@rajprakash00
Copy link
Contributor

Without giving any title it's obvious that whatever you write in editor comes in title be it image or file.So is with the markdown tag too.
Can you explain your issue more properly?

@roman-r-m
Copy link
Collaborator Author

roman-r-m commented Mar 26, 2020

Firstly, I should have clarified that I obverve this on mobile, though I suspect desktop version behaves the same.

What I mean is when I'm attaching a file, say, very_important_document.pdf it would be very convenient to have the note titled very_important_document.pdf rather than something like ![very_important_document.pdf](:/a0ec092858ac4fc28881437d85). Makes search much easier.

Does this make sense?

@rajprakash00
Copy link
Contributor

Yes,I got what you are saying. looking that way also if you write any bold or italic sentence instead of attaching file/image asteriks come in the title like **bold** in title it becomes bold** but according to you it should be bold

@coderrsid
Copy link
Contributor

This issue is already discussed in #1731

@roman-r-m
Copy link
Collaborator Author

This issue is already discussed in #1731

I don't think it's the same, unless I have missed something - that thread is quite long.

From what I saw that issue is about inserting urls and fetching the page title while what I had in mind was attaching files that already have names, just showing this name differently in note title.

@coderrsid
Copy link
Contributor

Ohh so you want the title of the file to the note title right? But would that make sense always?

@roman-r-m
Copy link
Collaborator Author

roman-r-m commented Mar 28, 2020

I can't think of a scenario where having markdown tag as title makes more sense than file name.

But to be clear this is only for the scenario where you create a new note, attach a file and save and the title is generated automatically. Obviously you can always set title youself and this will have priority over auto generated title.

@coderrsid
Copy link
Contributor

@PackElend and @bedwardly-down , can surely bring some insights here..

@PackElend
Copy link
Collaborator

idea sounds reasonable for me

@anihm136
Copy link
Contributor

I'd like to take this up

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants