Renaming a Tag adds it to SelectedNoteTags list regardless if such a NoteTag exists

[vsimkus]

Environment

Joplin version: 1.0.178
Platform: Linux
OS specifics: Debian Bullseye (Testing)

Steps to reproduce

1. Create a note and attach a tag.
2. Create another note without tags.
3. Rename the tag using the sidebar context menu.

Renaming a tag adds it to the top editor bar even though the note is not tagged with this particular tag. The note is not actually tagged, it only shows up in the top bar. If you switch the selected note to another one and back, then the tag will have disappeared from the top bar.

Describe what you expected to happen

Renaming a tag that is not associated with the currently selected note should not add the tag item to the top bar in the editor.

Screencast

The screencast doesn't show the renaming dialog, but I just change the name of the tag from "coding" to "coding_2".

[laurent22]

Indeed there's a bug here.

[Rishabh-malhotraa]

@vsimkus I'll look into it, thanks for pointing it out

[PRASHANT1104]

@Rishgod are you working on it ? If not , I would like to work on it.

[Chhekur]

@laurent22 I have fixed this issue and made a PR : #2680