Canceling print will put the UI in a locked up state without an obvious resolution (Linux only)

[taw00]

UPDATED description.

Joplin 1.0.179
OS: Fedora 31, Gnome 3.34

1. Open Joplin
2. Go to print something with CTRL-P
3. Cancel it.
4. Observe notification window that opens, but can't be removed excepted with the escape key which is perhaps non-obvious. Joplin is unusable until this action is taken.
5. Closing Joplin does not remove the notification window and Joplin cannot be restarted in a useful state. ... until that ESCAPE key is hit. There is not indication that the user needs to hit the escape key.

Fun! See attachment that shows the little window that opens up.

[taw00]

log.txt had no error. Nor did any other log files. But I was able to produce this. I hope it helps.

[tessus]

Hmm, this might be a Linux issue. It's also strange how the message looks like.

However, when cancelling, there should not be an error message at all. So there are actually 2 issues:

• error message after cancelling
• error message can't be dismissed (Linux)

With git master on macOS it looks like this:

[miciasto]

It doesn't hang on Ubuntu 18.04, though I do get the warning dialog without any button, which I clear by Escape key.

[miciasto]

@tessus

So there are actually 2 issues:
error message after cancelling
error message can't be dismissed (Linux)

The PR resolves the first issue.

The inability to dismiss a dialog box (@taw00) and a dialog box without OK button (me) are perhaps separate issues.

[miciasto]

a dialog box without OK button (me) are perhaps separate issues.

Upon investigating in the code, this is intentional. So this part is not a bug.

[tessus]

Upon investigating in the code, this is intentional.

This can't be. Otherwise there wouldn't be a button on macOS. Alao, please note the differences.
On macOS the dialog is bound to the main app window. On Linux it just pops up in the middle of the screen? Something is off.

[miciasto]

Otherwise there wouldn't be a button on macOS

The Joplin error message dialog (for all Joplin error messages) is defined without any specifying buttons. The Electron doc says:

buttons String - Array of texts for buttons. On Windows, an empty array will result in one button labeled "OK".

but doesn't specify what will happen on other platforms.

If I explicitly add an OK button to the Joplin error message, then I get one (on Linux).

Perhaps we should do this? Or do we leave it up to the Electron default behaviours on the different platforms?

[tessus]

I think we should add an OK button to bridge.js for showErrorMessageBox. But this is @laurent22's decision to make.

[taw00]

Oh, geez. I was able to dismiss it with the ESC key as well. GAH! I'm an idiot.
Still... that shouldn't be the behavior. :)

Updated the headline and description. At least I don't have to kill -9 the sucker. Heh.

[laurent22]

I think we should add an OK button to bridge.js for showErrorMessageBox. But this is @laurent22's decision to make.

Yes I agree, there should be an OK button by default. I can only assume that this is a bug in Electron that it's missing.

[miciasto]

Yes I agree, there should be an OK button by default. I can only assume that this is a bug in Electron that it's missing.

Great! The bug might be platform specific. In any case, the pending PR includes a work around for it, so it will work on all platforms regardless.