Mac OS - Emoji scramble #2244

D4nte · 2019-12-30T03:33:23Z

Environment

Joplin version:

Joplin 1.0.176 (prod, darwin)
Client ID: d0cffdc90adb49d0a7e9fcd2d1f7fc79
Sync Version: 1

Revision: 64a1408 (HEAD)

Platform: macOS Mojave 10.14.6

Steps To Reproduce

Create new note
Enter "foo"
Move cursor to the left of "foo": |foo
Press control+command+space to enter emoji
Select ✅ emoji: ✅foo

Expected: cursor works as usual.
Actual: The cursor has issues. | represents the cursor:

When moving the cursor to the right, at most it goes to here: ✅fo|o.
Then, when hitting backspace twice, the result is: ✅|f
When deleting using backspace, it deletes the character on the right of the cursor.

Logfile

console:

/Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12357 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Connect(HeaderComponent), Connect(MainScreenComponent), Connect(NavigatorComponent), Connect(NoteListComponent), Connect(NoteTextComponent), Connect(RootComponent), Connect(SideBarComponent), Provider
printWarning @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12357
/Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12357 Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Connect(HeaderComponent), Connect(MainScreenComponent), Connect(NavigatorComponent), Connect(NoteListComponent), Connect(NoteTextComponent), Connect(RootComponent), Connect(SideBarComponent)
printWarning @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12357
/Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12357 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Connect(NoteTextViewerComponent), Connect(ToolbarComponent), ReactAce
printWarning @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12357
lowPriorityWarningWithoutStack @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12378
ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12548
flushRenderPhaseStrictModeWarningsInDEV @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:25689
commitRootImpl @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:24937
unstable_runWithPriority @ /Applications/Joplin.app/Contents/Resources/app/node_modules/scheduler/cjs/scheduler.development.js:697
runWithPriority$2 @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12149
commitRoot @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:24922
finishSyncRender @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:24329
performSyncWorkOnRoot @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:24307
(anonymous) @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12199
unstable_runWithPriority @ /Applications/Joplin.app/Contents/Resources/app/node_modules/scheduler/cjs/scheduler.development.js:697
runWithPriority$2 @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12149
flushSyncCallbackQueueImpl @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12194
flushSyncCallbackQueue @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12182
scheduleUpdateOnFiber @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:23709
enqueueSetState @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:13994
Component.setState @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react/cjs/react.development.js:325
reloadNote @ /Applications/Joplin.app/Contents/Resources/app/gui/NoteText.min.js:651
_tickCallback @ internal/process/next_tick.js:68
async function (async)
reloadNote @ /Applications/Joplin.app/Contents/Resources/app/gui/NoteText.min.js:525
scheduleReloadNoteIID_.setTimeout @ /Applications/Joplin.app/Contents/Resources/app/gui/NoteText.min.js:514
setTimeout (async)
scheduleReloadNote @ /Applications/Joplin.app/Contents/Resources/app/gui/NoteText.min.js:513
UNSAFE_componentWillReceiveProps @ /Applications/Joplin.app/Contents/Resources/app/gui/NoteText.min.js:680
callComponentWillReceiveProps @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:14298
updateClassInstance @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:14511
updateClassComponent @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:18420
beginWork$1 @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:20186
beginWork$$1 @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:25756
performUnitOfWork @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:24695
workLoopSync @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:24671
performSyncWorkOnRoot @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:24270
(anonymous) @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12199
unstable_runWithPriority @ /Applications/Joplin.app/Contents/Resources/app/node_modules/scheduler/cjs/scheduler.development.js:697
runWithPriority$2 @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12149
flushSyncCallbackQueueImpl @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12194
flushSyncCallbackQueue @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12182
scheduleUpdateOnFiber @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:23709
enqueueSetState @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:13994
Component.setState @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react/cjs/react.development.js:325
onStateChange @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-redux/lib/components/connectAdvanced.js:222
notify @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-redux/lib/utils/Subscription.js:30
notifyNestedSubs @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-redux/lib/utils/Subscription.js:69
onStateChange @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-redux/lib/components/connectAdvanced.js:219
notify @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-redux/lib/utils/Subscription.js:30
notifyNestedSubs @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-redux/lib/utils/Subscription.js:69
onStateChange @ /Applications/Joplin.app/Contents/Resources/app/node_modules/react-redux/lib/components/connectAdvanced.js:219
dispatch @ /Applications/Joplin.app/Contents/Resources/app/node_modules/redux/lib/createStore.js:186
generalMiddleware @ /Applications/Joplin.app/Contents/Resources/app/lib/BaseApplication.js:394
generalMiddleware @ /Applications/Joplin.app/Contents/Resources/app/app.js:257
action @ /Applications/Joplin.app/Contents/Resources/app/lib/BaseApplication.js:331
refreshNotes @ /Applications/Joplin.app/Contents/Resources/app/lib/BaseApplication.js:283
_tickCallback @ internal/process/next_tick.js:68
/Applications/Joplin.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.development.js:12357 Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Connect(NoteTextViewerComponent), Connect(ToolbarComponent)

log.txt:
log.txt

The text was updated successfully, but these errors were encountered:

ABonner · 2020-01-09T02:17:31Z

Seems to only happen with certain emoji/unicode characters.

😀foo is fine

D4nte · 2020-01-10T01:10:02Z

Seems to only happen with certain emoji/unicode characters.

😀foo is fine

It looks like emojis that are 4 bytes are fine but the issue only appears with 3 bytes emojis: https://apps.timwhitlock.info/emoji/tables/unicode

ABonner · 2020-01-10T02:24:14Z

Appears to be an upstream bug in React-Ace, which is used for that editor panel.

Can be reproduced in the online demo http://securingsincity.github.io/react-ace/

ABonner · 2020-01-10T02:28:42Z

Which I guess is a React Wrapper around "Ace" which is a vanilla Javascript editor, with the same issue as well.

https://ace.c9.io/

lowne · 2020-01-13T13:21:59Z

😢 ajaxorg/ace#4142 FWIW

stale · 2020-04-12T13:37:14Z

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

dbogdanov · 2020-04-12T16:44:39Z

Still an issue.

tim-elmer · 2020-04-30T21:20:33Z

As suggested by the presence of an upstream issue (#2244 (comment)), this also affects Windows (and presumably any other platform using ace).

tim-elmer · 2020-06-14T02:16:14Z

With some minimal playing around, the Code Mirror editor (#3284) seems to solve the issue, at least with characters that I've observed breaking in Ace, as well as the ones listed in ajaxorg/ace#4142.

One oddity that I noticed is that compound emoji (?; not sure what to call them) are split into their components in the editor, but rendered as expected in the preview. Some examples; 🤦‍♀️, 👮‍♀️, 👨‍⚕️, 👨‍🌾. Screenshot:

I'm using the windows 1.0.220 build.

stale · 2020-07-14T04:14:49Z

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

D4nte · 2020-07-15T00:37:28Z

Not yet solved but looks like it's getting there.

stale · 2020-08-14T02:46:57Z

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

D4nte · 2020-08-17T04:51:57Z

Not resolved (just tested with 1.0.233 on Mac).

stale · 2020-09-16T05:38:17Z

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

D4nte · 2020-09-20T02:29:53Z

Not resolved on Joplin 1.0.245 (prod, darwin)

stale · 2020-10-20T03:11:10Z

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

D4nte · 2020-10-21T02:01:27Z

Resolved in Joplin 1.2.6 (prod, darwin)

D4nte added the bug It's a bug label Dec 30, 2019

stale bot added the stale An issue that hasn't been active for a while... label Apr 12, 2020

stale bot removed the stale An issue that hasn't been active for a while... label Apr 12, 2020

CalebJohn mentioned this issue Jun 4, 2020

Desktop: Replace Ace with Code mirror #3284

Merged

stale bot added the stale An issue that hasn't been active for a while... label Jul 14, 2020

stale bot removed the stale An issue that hasn't been active for a while... label Jul 15, 2020

stale bot added the stale An issue that hasn't been active for a while... label Aug 14, 2020

stale bot removed the stale An issue that hasn't been active for a while... label Aug 17, 2020

stale bot added stale An issue that hasn't been active for a while... and removed stale An issue that hasn't been active for a while... labels Sep 16, 2020

stale bot added the stale An issue that hasn't been active for a while... label Oct 20, 2020

D4nte closed this as completed Oct 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mac OS - Emoji scramble #2244

Mac OS - Emoji scramble #2244

D4nte commented Dec 30, 2019 •

edited

Loading

ABonner commented Jan 9, 2020

D4nte commented Jan 10, 2020

ABonner commented Jan 10, 2020

ABonner commented Jan 10, 2020

lowne commented Jan 13, 2020

stale bot commented Apr 12, 2020

dbogdanov commented Apr 12, 2020

tim-elmer commented Apr 30, 2020

tim-elmer commented Jun 14, 2020 •

edited

Loading

stale bot commented Jul 14, 2020

D4nte commented Jul 15, 2020

stale bot commented Aug 14, 2020

D4nte commented Aug 17, 2020

stale bot commented Sep 16, 2020

D4nte commented Sep 20, 2020

stale bot commented Oct 20, 2020

D4nte commented Oct 21, 2020

Mac OS - Emoji scramble #2244

Mac OS - Emoji scramble #2244

Comments

D4nte commented Dec 30, 2019 • edited Loading

Environment

Steps To Reproduce

Logfile

ABonner commented Jan 9, 2020

D4nte commented Jan 10, 2020

ABonner commented Jan 10, 2020

ABonner commented Jan 10, 2020

lowne commented Jan 13, 2020

stale bot commented Apr 12, 2020

dbogdanov commented Apr 12, 2020

tim-elmer commented Apr 30, 2020

tim-elmer commented Jun 14, 2020 • edited Loading

stale bot commented Jul 14, 2020

D4nte commented Jul 15, 2020

stale bot commented Aug 14, 2020

D4nte commented Aug 17, 2020

stale bot commented Sep 16, 2020

D4nte commented Sep 20, 2020

stale bot commented Oct 20, 2020

D4nte commented Oct 21, 2020

D4nte commented Dec 30, 2019 •

edited

Loading

tim-elmer commented Jun 14, 2020 •

edited

Loading