Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] user-agent header setting for webdav (or other remote) sources #2042

Closed
Ardakilic opened this issue Oct 29, 2019 · 2 comments · Fixed by #2064
Closed

[request] user-agent header setting for webdav (or other remote) sources #2042

Ardakilic opened this issue Oct 29, 2019 · 2 comments · Fixed by #2064
Assignees
Labels
bug It's a bug

Comments

@Ardakilic
Copy link
Contributor

Ardakilic commented Oct 29, 2019

Heya,

It would be awesome if we could set our own user agent for Joplin through the settings pages.

I'm blacklisting various user-agent strings to blacklist some known crawlers from my self-hosted Seafile instance, however, because Joplin uses node-fetch's user agent directly, which is node-fetch/1.0 (+https://github.com/bitinn/node-fetch) currently, it gets stuck on my blacklist word list because it contains the word github.

I can simplify my wordlist, or make a whitelist for node-fetch, however, these won't be a proper way to whitelist Joplin on my server directly, or won't let me write rules specifically for Joplin.

Environment

Joplin version: Joplin 1.0.170 (prod, darwin) (but possibly for all versions)
Platform: OSX (but possibly for all versions)

Steps To Reproduce

  1. Create a dummy http bin to check headers such as https://postb.in/
  2. Set webdav url to this bin to check user-agent header
  3. It's node-fetch/1.0 (+https://github.com/bitinn/node-fetch)

I would appreciate if this would be considered.

Thanks in advance,

@AlexPaphitis
Copy link

Hi hope you're well :)

I submitted this pull request to solve this #2050

Thank you,
Alex

@Ardakilic
Copy link
Contributor Author

Hey @AlexPaphitis , awesome! Thanks for the work you've done over this 👍

tessus added a commit to tessus/joplin that referenced this issue Nov 5, 2019
@lock lock bot locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants