Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issues (delete notebook/tags/notes) #1662

Closed
tessus opened this issue Jun 16, 2019 · 4 comments · Fixed by #1934
Closed

UI issues (delete notebook/tags/notes) #1662

tessus opened this issue Jun 16, 2019 · 4 comments · Fixed by #1934
Labels
desktop All desktop platforms upstream There's a problem with upstream code.

Comments

@tessus
Copy link
Collaborator

tessus commented Jun 16, 2019

Operating system

  • macOS

Application

  • Desktop

I've opened only one issue, because they are all related.
I have noticed problems with the dialog boxes for the following actions:

Delete notebook (right click on a notebook, select Delete)

OK is selected by default. This is dangerous.
It is not possible to use the keyboard to switch between Cancel and OK.
OK button should be renamed to Delete or DELETE.
Cancel should be selected by default.

Delete tags (right click on a tag, select Delete)

The context menu item should be renamed from Delete to Remove. We are not deleting the tag.

OK is selected by default. This is dangerous.
It is not possible to use the keyboard to switch between Cancel and OK.
OK button should be renamed to Remove or REMOVE.
Cancel should be selected by default.

Delete a single note or multiple notes

No button is selected by default. It is not possible to use the keyboard to select Cancel or Delete.
Cancel should be selected by default.
If above dialog boxes were to use UPPERCASE for remove/delete, so should this one.

image

@laurent22 I remember you added a change a while back, so I am not sure why this is happening.

@tessus tessus added the desktop All desktop platforms label Jun 16, 2019
@tessus
Copy link
Collaborator Author

tessus commented Jul 2, 2019

I suspect this is an Electron bug. At least the part where nothing is selected, because defaultId: 1 is set in the code.

@stale
Copy link

stale bot commented Sep 30, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Sep 30, 2019
@tessus tessus added the upstream There's a problem with upstream code. label Sep 30, 2019
@stale stale bot removed the stale An issue that hasn't been active for a while... label Sep 30, 2019
@tessus
Copy link
Collaborator Author

tessus commented Oct 1, 2019

@laurent22 I would like to follow up on this. While I can't do anything against the fact that setting the button to Cancel by default does not work, I can still work on the other issues.

  • renaming the context menu item
  • renaming the button

Please let me know what you think.

@tessus
Copy link
Collaborator Author

tessus commented Oct 1, 2019

@laurent22 I will create a PR and you can decide then

tessus added a commit to tessus/joplin that referenced this issue Oct 1, 2019
…lete, remove) and context menu (for tags)

fixes laurent22#1662 (partially, because I can't fix the upstream issue, unless we update Electron)
laurent22 pushed a commit that referenced this issue Oct 3, 2019
…tions (#1934)

* set cancel as the  default in dangerous operations, rename buttons (delete, remove) and context menu (for tags)

fixes #1662 (partially, because I can't fix the upstream issue, unless we update Electron)

* add default value for buttonLabel
@lock lock bot locked and limited conversation to collaborators Oct 14, 2019
scoroi pushed a commit to scoroi/joplin that referenced this issue Nov 10, 2019
…ous operations (laurent22#1934)

* set cancel as the  default in dangerous operations, rename buttons (delete, remove) and context menu (for tags)

fixes laurent22#1662 (partially, because I can't fix the upstream issue, unless we update Electron)

* add default value for buttonLabel
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
desktop All desktop platforms upstream There's a problem with upstream code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant