-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI issues (delete notebook/tags/notes) #1662
Comments
I suspect this is an Electron bug. At least the part where nothing is selected, because |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions. |
@laurent22 I would like to follow up on this. While I can't do anything against the fact that setting the button to Cancel by default does not work, I can still work on the other issues.
Please let me know what you think. |
@laurent22 I will create a PR and you can decide then |
…lete, remove) and context menu (for tags) fixes laurent22#1662 (partially, because I can't fix the upstream issue, unless we update Electron)
…ous operations (laurent22#1934) * set cancel as the default in dangerous operations, rename buttons (delete, remove) and context menu (for tags) fixes laurent22#1662 (partially, because I can't fix the upstream issue, unless we update Electron) * add default value for buttonLabel
Operating system
Application
I've opened only one issue, because they are all related.
I have noticed problems with the dialog boxes for the following actions:
Delete notebook (right click on a notebook, select Delete)
OK
is selected by default. This is dangerous.It is not possible to use the keyboard to switch between
Cancel
andOK
.OK
button should be renamed toDelete
orDELETE
.Cancel
should be selected by default.Delete tags (right click on a tag, select Delete)
The context menu item should be renamed from
Delete
toRemove
. We are not deleting the tag.OK
is selected by default. This is dangerous.It is not possible to use the keyboard to switch between
Cancel
andOK
.OK
button should be renamed toRemove
orREMOVE
.Cancel
should be selected by default.Delete a single note or multiple notes
No button is selected by default. It is not possible to use the keyboard to select
Cancel
orDelete
.Cancel
should be selected by default.If above dialog boxes were to use UPPERCASE for remove/delete, so should this one.
@laurent22 I remember you added a change a while back, so I am not sure why this is happening.
The text was updated successfully, but these errors were encountered: