Desktop, Cli: Fixes #3402: Fixed import of checkboxes in ENEX files

laurent22 · Jun 28, 2020 · acf1ff6 · acf1ff6
1 parent 05acc51
commit acf1ff6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CliClient/tests/enex_to_html/checklist-list.html b/CliClient/tests/enex_to_html/checklist-list.html
@@ -3,7 +3,7 @@
     <p>For example, consider an exported Evernote list with todo checkboxes like this:</p>
     <ul>
       <li>
-        <div><input type="checkbox" onclick="return false;">Foo</div>
+        <div><input checked="checked" type="checkbox" onclick="return false;">Foo</div>
       </li>
       <li>
         <div><input type="checkbox" onclick="return false;"><b>Bar</b></div>

diff --git a/ReactNativeClient/lib/import-enex-html-gen.js b/ReactNativeClient/lib/import-enex-html-gen.js
@@ -123,7 +123,9 @@ function enexXmlToHtml_(stream, resources) {
 					section.lines = addResourceTag(section.lines, resource, nodeAttributes);
 				}
 			} else if (tagName == 'en-todo') {
-				section.lines.push('<input type="checkbox" onclick="return false;" />');
+				const nodeAttributes = attributeToLowerCase(node);
+				const checkedHtml = nodeAttributes.checked && nodeAttributes.checked.toLowerCase() == 'true' ? ' checked="checked" ' : ' ';
+				section.lines.push(`<input${checkedHtml}type="checkbox" onclick="return false;" />`);
 			} else if (isSelfClosingTag(tagName)) {
 				section.lines.push(`<${tagName}${attributesStr}/>`);
 			} else {