Add support for custom typed values #1
+67
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add an option to allow values outside the options to be
commited. In my use case, I just want to show options as suggestions so
the user should be able to use whatever he typed as the value if he
wants to.
Also, send the `this.label` so that we it makes it easier to pattern
match the event in LiveView insteaf of using the `input[name]`. For
instance:
```Elixir
def handle_event("autocomplete-commit", %{"label" => "my-label", "value" => value}, socket) do
...
end
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏼
Thanks for the library. Here is something I missed while using this library so I'm using my fork for now. Let me know if that make sense to be part of this library instead.
This commit add an option to allow values outside the options to be commited. In my use case, I just want to show options as suggestions so the user should be able to use whatever he typed as the value if he wants to.
Also, send the
this.labelso that we it makes it easier to pattern match the event in LiveView insteaf of using theinput[name]. For instance: