Skip to content

fix how we find num replicas for endpoints and collectors#340

Merged
boetro merged 3 commits intolaunchflow:mainfrom
boetro:main
Dec 22, 2023
Merged

fix how we find num replicas for endpoints and collectors#340
boetro merged 3 commits intolaunchflow:mainfrom
boetro:main

Conversation

@boetro
Copy link
Contributor

@boetro boetro commented Dec 21, 2023

No description provided.

@boetro boetro requested a review from JoshTanke as a code owner December 21, 2023 22:21
@codecov
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5e959fe) 74.65% compared to head (03d3ed3) 74.65%.

Files Patch % Lines
...tors/collector_pattern/receive_process_push_ack.py 0.00% 1 Missing ⚠️
...actors/endpoint_pattern/receive_process_respond.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files         168      168           
  Lines        7561     7561           
=======================================
  Hits         5645     5645           
  Misses       1916     1916           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boetro boetro merged commit a899c7b into launchflow:main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants