feat: support prerequisite relation data in all_flags_detail #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sdk-693-client-prereq-references
branch
from
354d42a to
245b206
Compare
cwaldren-ld
commented
Oct 18, 2024
| } | ||
|
|
||
| let detail = evaluate(store.to_store(), &flag, context, None); | ||
| let event_recorder = DirectPrerequisiteRecorder::new(key.clone()); |
Contributor
Author
There was a problem hiding this comment.
Could save a clone and take a reference, then give it back after we're done.. but seems not worth it.
cwaldren-ld
force-pushed
the
cw/sdk-693-client-prereq-references
branch
from
ab366ee to
aeb94ce
Compare
cwaldren-ld
commented
Oct 21, 2024
| )); | ||
| } | ||
|
|
||
| #[test] |
Contributor
Author
There was a problem hiding this comment.
We didn't have any all_flags_detail tests (that I could find), so added some basic ones here.
cwaldren-ld
force-pushed
the
cw/sdk-693-client-prereq-references
branch
from
7ba4a7d to
97becaf
Compare
cwaldren-ld
changed the title
keelerm84
approved these changes
Oct 24, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Oct 25, 2024
🤖 I have created a release *beep* *boop* --- ## [2.3.0](2.2.1...2.3.0) (2024-10-24) ### Features * support prerequisite relation data in all_flags_detail ([#99](#99)) ([d0ad003](d0ad003)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
FlagDetailstruct returned byall_flags_detailto contain prerequisite relations for flags.