feat: Add option to enable compression of event payloads #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sdk-837/gzip
branch
from
9641ec0 to
7ceefae
Compare
keelerm84
force-pushed
the
mk/sdk-837/gzip
branch
from
7ceefae to
02f7b77
Compare
keelerm84
force-pushed
the
mk/sdk-837/gzip
branch
from
c1ba366 to
02501df
Compare
cwaldren-ld
reviewed
Dec 4, 2024
cwaldren-ld
reviewed
Dec 4, 2024
|
|
||
| // mut is needed for event-compression feature | ||
| #[allow(unused_mut)] | ||
| let mut additional_headers = self.default_headers.clone(); |
Contributor
There was a problem hiding this comment.
Might be not worth it in terms of readability, but possibly this could conditionally be mut if event-compression is enabled, and not mut otherwise.
Member
Author
There was a problem hiding this comment.
I have to do the same thing with the json bit above, so the readability doesn't seem good. I'm inclined to leave it.
cwaldren-ld
approved these changes
Dec 5, 2024
keelerm84
pushed a commit
that referenced
this pull request
Dec 10, 2024
🤖 I have created a release *beep* *boop* --- ## [2.4.0](2.3.0...2.4.0) (2024-12-05) ### Features * Add option to enable compression of event payloads ([#102](#102)) ([5cc7aac](5cc7aac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.