Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Inline context for custom events

This PR updates the Roku SDK to include the full context in custom events rather than just contextKeys, and updates the capabilities to include "inline-context-all" instead of "inline-context".

Changes

  • Updated HttpServerTask.brs to replace "inline-context" with "inline-context-all" in the capabilities list
  • Updated LaunchDarklyEventProcessor.brs to include the full context in custom events instead of just contextKeys
  • Updated Test__Client.brs to reflect the change from contextKeys to full context

This change aligns with the Ruby SDK implementation in this commit.

Link to Devin run: https://app.devin.ai/sessions/89e3854c9a764913947ac5494e21b06f
Requested by: mkeeler@launchdarkly.com

Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner April 21, 2025 17:51
Copy link
Contributor Author

Original prompt from mkeeler@launchdarkly.com:

Received message in Slack channel #sdks-roku-brightscript:

@Devin I would like you to translate the work done in ruby at <https://github.com/launchdarkly/ruby-server-sdk/commit/ab5b14fff2f04f1dfa7e6f61669bc348fffb5cac> to the <https://github.com/launchdarkly/roku-client-sdk> repository.

Make sure you replace the inline-context capability with inline-context-all.

You can see some of the work we did to inline a context last time here <https://github.com/launchdarkly/roku-client-sdk/commit/86099052dcad6deb8dc26250b687eb65baa7c310>

Name this branch mk/sdk-1168/inline

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@keelerm84 keelerm84 merged commit 3831c29 into main Apr 21, 2025
2 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1168/inline branch April 21, 2025 20:54
keelerm84 pushed a commit that referenced this pull request Apr 21, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.4.0](2.3.0...2.4.0)
(2025-04-21)


### Features

* Inline context for custom events
([#42](#42))
([3831c29](3831c29))


### Bug Fixes

* Drop empty application id or version
([#44](#44))
([3f8e857](3f8e857))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant