chore: Update poetry instructions #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Add missing make target; update poetry instructions
This PR applies the same changes made to CONTRIBUTING.md in python-server-sdk PR #338 to maintain consistency across LaunchDarkly Python repositories.
Changes Made
poetry install
followed byeval $(poetry env activate)
instead ofpoetry shell
Rationale
The original
poetry shell
command can sometimes cause issues in certain environments. The updated approach usingeval $(poetry env activate)
provides a more reliable way to activate the poetry virtual environment while making the activation step optional for developers who prefer to manage their environment differently.Testing Transparency
What I Actually Checked
What I Did Not Check
Reviewer Checklist
Link to Devin run: https://app.devin.ai/sessions/53474e9243c3429fa6fad0798fa5b5bd
Requested by: mkeeler@launchdarkly.com