Skip to content

V2 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 3, 2016
Merged

V2 #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dc4ee02
[wip] V2 data model + evaluation start.
Jul 28, 2016
7221ffc
[wip] V2 data model + evaluation start.
Jul 28, 2016
02f4118
[wip] V2 eval works.
Aug 1, 2016
5b9defd
[wip] Move some things out of big file.
Aug 1, 2016
2ce8d58
[wip] v2 events work ok- but not prereqs.
Aug 1, 2016
100d34d
[wip] v2 events work ok including prereqs.
Aug 1, 2016
6beeb75
Use standard logging interface. Log more/better things
Aug 1, 2016
35766f3
Remove v1 code. Other cleanup
Aug 1, 2016
c191a07
update version.
Aug 1, 2016
efe65f9
remove whitespace
Aug 1, 2016
674dc1b
Address PR comments. Deprecate toggle function. Remove getFlag function
Aug 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Your first feature flag
2. In your application code, use the feature's key to check whether the flag is on for each user:

$user = new LaunchDarkly\LDUser("user@test.com");
if ($client->toggle("your.flag.key", $user)) {
if ($client->variation("your.flag.key", $user)) {
# application code to show the feature
} else {
# the code to run if the feature is off
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.0
2.0.0
4 changes: 3 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
}
],
"require": {
"php": ">=5.5"
"php": ">=5.5",
"psr/log": "1.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings in https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md

},
"require-dev": {
"guzzlehttp/guzzle": "6.2.1",
Expand All @@ -27,6 +28,7 @@
"suggested": {
"guzzlehttp/guzzle": "6.2.1",
"kevinrob/guzzle-cache-middleware": "1.4.1",
"monolog/monolog": "1.21.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monolog: https://github.com/Seldaek/monolog implements PSR-3

"predis/predis": "1.0.*"
},
"autoload": {
Expand Down
Loading