support Predis 2.x and SDK 5.x #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our integration code doesn't rely on any Predis APIs that have actually changed between 1.x and 2.x. So I think all that's needed here is to relax the dependency constraint to allow both, and to make sure we're testing with both in CI.
There are Predis configuration options that have changed in 2.x, but that just means that if an application passes custom options through by setting
predis_options, they need to set them correctly for whichever version of Predis the application is using.I also relaxed the PHP SDK dependency to support the next major version, 5.0, because we're not introducing any internal API changes in that release that would affect this database integration.