Shorthand client configuration doesn't allow scheme to be specified

[mriccid]

When instantiating the feature requester using the shorthand options syntax (i.e. an options array rather than a ClientInterface instance) it's not possible to specify the scheme. This means that for those who require a TLS connection they must instantiate a Predis client to pass in.

Would it be possible to allow the scheme to be provided in the options array, and default to TCP if it's empty? This seems like a small change that would make it much simpler to configure this feature requester when using TLS.

I was imagining it would be as simple as this:

"scheme" => $options['redis_scheme'] ?? "tcp"

Note: I wasn't sure on what was required in the ticket, so let me know if you need me to provide more information. I'm also unsure of what the expectations are for pull requests in this repository, but I would be happy to make this change myself and create a pull request with some guidance on how to contribute.

[bwoskow-ld]

Hi @mriccid,

This sounds reasonable. We will try to take a look at it soon.

Cheers,
@bwoskow-ld

Filed internally as 124511.

[eli-darkly]

@mriccid We're going to implement this in a slightly more general way where, instead of adding more top-level options corresponding to options supported by Predis (as for instance someone might want to set the ssl parameters), we'll let you pass in a predis_options named array that can contain any of those, and we'll pass them straight through to Predis. So in this case, you would set "predis_options" => ["scheme" => "tcp"]. The existing options like host and port could be set in either place.

[eli-darkly]

This is now implemented in the 1.1.0 release.