feat: Add ability to specify password for the redis server #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurustephen
changed the title
keelerm84
approved these changes
Oct 10, 2024
keelerm84
pushed a commit
that referenced
this pull request
Oct 10, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](1.2.0...1.3.0) (2024-10-10) ### Features * Add ability to specify password for the redis server ([#20](#20)) ([233e481](233e481)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thank you for your contribution. This has been released in v1.3.0 |
|
I appreciate the quick turnaround! Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title describes, this should be a straightforward change allowing a password to be specified when connecting to the redis server. I don't anticipate that this would cause any problems, but please double check my work.
I understand that there is a
phpredis_clientclient option we could use instead to pass in a functional phpredis client with a password, but this approach would be easier for us to manage due to differences in our development and production environments.I would be grateful for a speedy release, so please let me know if I can help. Thank you for your time!