-
Notifications
You must be signed in to change notification settings - Fork 2
feat: take transformed coordinates, which are more precise in animation #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* andrey/nonstandard-views: Attached dialog sample space use Canvas for certain types of windows consolidate in one view sample of adding floating views add floating button test: Add UI and logic to evaluate boolean flags (#305)
…ed-mask2 * andrey/do-not-send-duplicate-windows: Unit tests Volatile address feedback Fix feedback Recycle bitmap early fix size bug no message
* main: feat: support non-standard windows added by WindowManager (#306)
* main: feat: recursive mask collection (#308) # Conflicts: # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/ComposeMaskTarget.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/Mask.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskCollector.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/MaskMatcher.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt
Outdated
Show resolved
Hide resolved
...droid/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/ComposeMaskTarget.kt
Show resolved
Hide resolved
agrognetti
approved these changes
Dec 4, 2025
...ervability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/Mask.kt
Outdated
Show resolved
Hide resolved
...ervability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/Mask.kt
Outdated
Show resolved
Hide resolved
...ndroid/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
Outdated
Show resolved
Hide resolved
...y-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt
Show resolved
Hide resolved
...ndroid/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
Show resolved
Hide resolved
Merged
abelonogov-ld
pushed a commit
that referenced
this pull request
Dec 4, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-android: 0.19.0</summary> ## [0.19.0](launchdarkly-observability-android-0.18.0...launchdarkly-observability-android-0.19.0) (2025-12-04) ### Features * take transformed coordinates, which are more precise in animation ([#309](#309)) ([5d669d4](5d669d4)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release `observability-android` 0.19.0, updating versions and changelog with a feature to use transformed coordinates for more precise animation handling. > > - **Android SDK (`sdk/@launchdarkly/observability-android`)**: > - Version bump to `0.19.0` in `gradle.properties` and `.release-please-manifest.json`. > - Changelog updated with feature: use transformed coordinates for improved precision during animations. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7636155. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
abelonogov-ld
added a commit
that referenced
this pull request
Dec 4, 2025
* main: doc: Add using ldMask in readme. (#311) chore: release main (#312) feat: take transformed coordinates, which are more precise in animation (#309) chore: release main (#307) fix(SEC-7530): update react-server-dom-webpack to 19.0.1 (#310) # Conflicts: # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/CaptureSource.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/ComposeMaskTarget.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/Mask.kt # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
abelonogov-ld
added a commit
that referenced
this pull request
Dec 4, 2025
* main: (85 commits) doc: Add using ldMask in readme. (#311) chore: release main (#312) feat: take transformed coordinates, which are more precise in animation (#309) chore: release main (#307) fix(SEC-7530): update react-server-dom-webpack to 19.0.1 (#310) feat: recursive mask collection (#308) feat: support non-standard windows added by WindowManager (#306) feat: Android SR Do not send duplicate screens (#304) test: Add UI and logic to evaluate boolean flags (#305) chore: release main (#303) feat: Android Dialog Capture (#302) chore: Update Android Test main screen (#301) chore: release main (#300) feat: XML Views Automasking options (#299) fix: missed imports (#298) chore: release main (#297) feat: Support ldMask() for Native and Compose views. (#295) chore: release main (#296) fix: tweaks Android InteractionDetector to delegate additional defaul… (#294) chore: release main (#293) ... # Conflicts: # e2e/react-router/src/ldclientLazy.tsx # e2e/react-router/src/routes/root.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Take transformed coordinates, which are more precise in animation for both XML and Compose case using 4 points method.
How did you test this change?
Are there any deployment considerations?
Note
Switch masking to transformed 4-point polygons for Compose and Views, refactor collection via MaskContext, render via Path, and add a rotating credit card section in the demo form.
points) for both Compose and native views; draw viaPathinCaptureSource.drawMasks.MaskTarget.mask(context)signature;Masknow holdsrect,viewId, and optionalpoints(removedmatrix).MaskCollector.MaskContext(sharedMatrix,rootX/Y, matchers) and update traversal to pass context.ComposeMaskTarget.pointsandNativeMaskTarget.points(API 29+).credit_card_sectionand add continuous Y-rotation animation inXMLUserFormActivityto exercise transformed masking.Written by Cursor Bugbot for commit b6e9440. This will update automatically on new commits. Configure here.