This repository was archived by the owner on May 30, 2024. It is now read-only.
fix key prefix logic #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-darkly
commented
Jan 16, 2019
| @@ -194,7 +194,7 @@ function dynamoDBFeatureStoreInternal(tableName, options) { | |||
|
|
|||
| function marshalItem(kind, item) { | |||
| return { | |||
| namespace: kind.namespace, | |||
| namespace: namespaceForKind(kind), | |||
There was a problem hiding this comment.
This is the fix.
apucacao
approved these changes
Jan 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a dumb mistake I made in adding the key prefix feature in 1.1.0; it didn't work because the prefix was only being used for writes, not for reads.
It also makes use of some extra unit test functionality added in ldclient-node 5.7.1 so that we are now actually testing that feature (as we now do for all feature stores).