Skip to content

[sc-169181] code refs alias file patterns support doublestar in globs #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2022
Merged

[sc-169181] code refs alias file patterns support doublestar in globs #281

merged 3 commits into from
Nov 10, 2022

Conversation

jazanne
Copy link
Contributor

@jazanne jazanne commented Sep 14, 2022 •
edited
Loading

use doublestar lib for glob

enable aliases like

aliases: 
  type: filepattern
  name: "go aliases"
  paths: 
    - "**/*.go"
  patterns: 
    - "export const (\\w+) = flagPredicate\\(\\s*'FLAG_KEY'"

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #169181: code refs alias file patterns should support doublestar in glob.

@jazanne jazanne linked an issue Sep 14, 2022 that may be closed by this pull request
Feature: support recursive globbing when finding aliases #151
Closed
@jazanne jazanne changed the title Jwhite/sc 169181/code refs alias file patterns should support [sc-169181] code refs alias file patterns support doublestar in globs Nov 8, 2022
@jazanne jazanne force-pushed the jwhite/sc-169181/code-refs-alias-file-patterns-should-support branch from f3fb9b6 to 4ae6745 Compare November 8, 2022 20:21
@jazanne jazanne marked this pull request as ready for review November 8, 2022 20:21
@jazanne jazanne requested review from a team and InTheCloudDan November 8, 2022 20:21
@jazanne jazanne force-pushed the jwhite/sc-169181/code-refs-alias-file-patterns-should-support branch from 4ae6745 to 47279ac Compare November 8, 2022 20:36
@jazanne jazanne requested a review from a team November 8, 2022 20:36
mmrj
mmrj approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@mmrj mmrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ from Docs reviewers, I looked at the non-vendor files.

@jazanne jazanne force-pushed the jwhite/sc-169181/code-refs-alias-file-patterns-should-support branch from 47279ac to 0eca047 Compare November 10, 2022 16:03
@jazanne jazanne merged commit 7a9d020 into main Nov 10, 2022
@jazanne jazanne deleted the jwhite/sc-169181/code-refs-alias-file-patterns-should-support branch November 10, 2022 16:08
Gitnitdun
Gitnitdun reviewed Nov 22, 2022
View reviewed changes
Copy link

@Gitnitdun Gitnitdun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gitnitdun Gitnitdun Gitnitdun left review comments

@mmrj mmrj mmrj approved these changes

@mfreundlich mfreundlich mfreundlich approved these changes

@InTheCloudDan InTheCloudDan Awaiting requested review from InTheCloudDan

@karayusuf karayusuf Awaiting requested review from karayusuf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: support recursive globbing when finding aliases
4 participants
@jazanne @mmrj @Gitnitdun @mfreundlich