-
Notifications
You must be signed in to change notification settings - Fork 9
feat(icons): add script to automatically pull icons from Figma #1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: badb18e The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
'sidebar-left-collapse', | ||
'sidebar-left-expand', | ||
'sidebar-right-collapse', | ||
'sidebar-right-expand', | ||
'slash', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we lost this icon and it's used in breadcrumbs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this one and a few others were never added to Figma. Going through and adding those back now
commit: |
Size Change: 0 B Total Size: 530 kB ℹ️ View Unchanged
|
Summary
Adds a script to pull icons from Figma. This will make it much easier for adding icons so devs just need to create a branch, run the script and open a PR. It does require that icons be merged into LaunchPad figma before being able to add them, but I think that's a constraint that feels more like a feature than a bug so our icons don't get out of sync. Also reduces the mistakes that are often added in icon PRs such as not putting symbols in alphabetical order or drift between figma component names and icon ids.
What it does:
How to use
pnpm nx run @launchpad-ui/icons:sync
TODO/Questions:
diff between current LP-ui and Figma icons:
[icons:diff] New icons added: arrow-merge-both, chart-bell-curvearrow-merge, arrow-up-right, backslash,chart-bell, coins, json, map-check, osmo, rocket, sandbox,slash, stack, thumb-up, workflow