refactor(components): use vanilla-extract for styles #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a1157d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erangeles
approved these changes
Jan 4, 2024
Niznikr
commented
Jan 4, 2024
Comment on lines
+19
to
+23
| selectors: { | ||
| ['[data-theme="dark"] &']: { | ||
| vars: { [accentVar]: vars.color.pink[200] }, | ||
| }, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Simple example of how to tweak a local CSS custom property (component-level token) for dark mode.
Contributor
|
Size Change: -4.25 kB (-2%) Total Size: 191 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While StyleX provides some nice optimizations via atomic CSS, a couple drawbacks became apparent when trying to create styles for buttons: debugging the long list of classes via the browser dev tools is a pain (common for all atomic CSS solutions) and there isn't a way to target ancestor selectors (in this case dark mode via data-theme attr) for styles. Vanilla Extract does not have either of these issues and makes it easy to define locally scoped CSS custom properties. I believe VE's versatility and wider feature set at the expense of a larger CSS bundle size is a better fit for our needs in the long run.