Skip to content

fix: Discard events from closed connections. #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025

Conversation

kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented May 21, 2025

This PR + #842 should help to prevent issues like #840.

Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 24597 bytes
Size limit: 25000

Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 21183 bytes
Size limit: 25000

@kinyoklion kinyoklion marked this pull request as ready for review May 21, 2025 22:43
@kinyoklion kinyoklion requested a review from a team as a code owner May 21, 2025 22:43
Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 16055 bytes
Size limit: 20000

@kinyoklion kinyoklion merged commit 8119afe into main Jun 3, 2025
25 checks passed
@kinyoklion kinyoklion deleted the rlamb/sdk-1215/no-events-closed-polling branch June 3, 2025 18:30
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
kinyoklion pushed a commit that referenced this pull request Jun 3, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>browser-telemetry: 1.0.9</summary>

##
[1.0.9](browser-telemetry-v1.0.8...browser-telemetry-v1.0.9)
(2025-06-03)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/js-client-sdk bumped from 0.7.0 to 0.7.1
</details>

<details><summary>jest: 0.1.8</summary>

##
[0.1.8](jest-v0.1.7...jest-v0.1.8)
(2025-06-03)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/react-native-client-sdk bumped from ~10.10.2 to ~10.10.3
</details>

<details><summary>js-client-sdk: 0.7.1</summary>

##
[0.7.1](js-client-sdk-v0.7.0...js-client-sdk-v0.7.1)
(2025-06-03)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk-common bumped from 1.14.0 to 1.14.1
</details>

<details><summary>js-client-sdk-common: 1.14.1</summary>

##
[1.14.1](js-client-sdk-common-v1.14.0...js-client-sdk-common-v1.14.1)
(2025-06-03)


### Bug Fixes

* Discard events from closed connections.
([#867](#867))
([8119afe](8119afe))
</details>

<details><summary>react-native-client-sdk: 10.10.3</summary>

##
[10.10.3](react-native-client-sdk-v10.10.2...react-native-client-sdk-v10.10.3)
(2025-06-03)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk-common bumped from 1.14.0 to 1.14.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants