Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Introduce TestData#delete to simplify testing of flag deletion. #328

Closed
wants to merge 1 commit into from

Conversation

dmvk
Copy link

@dmvk dmvk commented May 17, 2024

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

I'm writing a custom dataStore that allows falling back to k8s configmap and I don't have a simple way to test tombstones.

@dmvk dmvk requested a review from a team May 17, 2024 14:04
@tanderson-ld
Copy link
Contributor

Hi @dmvk , thank you for the contribution. We are working to migrate this repository to our java-core repo and so this may get released mid next week if that repo migration goes to plan. Does that sound satisfactory?

@tanderson-ld
Copy link
Contributor

Planning to merge around the same time as the java-server-sdk is migrated to use this added functionality as a CI/CD build system update test.

@dmvk
Copy link
Author

dmvk commented May 18, 2024

@tanderson-ld Thanks, that sounds great, I haven't expected things to go this fast <3 Looking forward for the release!

@tanderson-ld
Copy link
Contributor

tanderson-ld commented May 23, 2024

Migrated your changes to the new repo. Once those are merged we'll release your change: launchdarkly/java-core#21

@tanderson-ld
Copy link
Contributor

java-core PR has merged launchdarkly/java-core#21

@tanderson-ld
Copy link
Contributor

The code changes are now released in java-server-sdk 7.5.0. Let us know if it works! This is a good verification of our reshuffling of our release pipeline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants