prepare 4.9.0 release

.circleci/config.yml

@@ -11,7 +11,6 @@ experimental:
 
 defaults:
   environment: &environment
-    GOLANGCI_LINT_VERSION: v1.10.2
     CIRCLE_TEST_REPORTS: /tmp/circle-reports
     CIRCLE_ARTIFACTS: /tmp/circle-artifacts
     COMMON_GO_PACKAGES: >
@@ -23,8 +22,7 @@ defaults:
     steps:
       - checkout
       - run: go get -u $COMMON_GO_PACKAGES
-      - run: curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s $GOLANGCI_LINT_VERSION
-      - run: ./bin/golangci-lint run ./...
+      - run: make lint
       - run: dep ensure -dry-run
 
       - run:
@@ -33,8 +31,7 @@ defaults:
             mkdir -p $CIRCLE_TEST_REPORTS
             mkdir -p $CIRCLE_ARTIFACTS
             trap "go-junit-report < $CIRCLE_ARTIFACTS/report.txt > $CIRCLE_TEST_REPORTS/junit.xml" EXIT
-            # Note, we need to specify all these packages individually for go test in order to remain 1.8-compatible
-            go test -race -v . ./redis ./ldconsul ./lddynamodb ./ldfiledata ./ldfilewatch ./utils | tee >(richgo testfilter) > $CIRCLE_ARTIFACTS/report.txt
+            make test | tee >(richgo testfilter) > $CIRCLE_ARTIFACTS/report.txt
 
       - store_test_results:
           path: /tmp/circle-reports

.gitignore

@@ -0,0 +1 @@
+bin/

CONTRIBUTING.md

@@ -18,29 +18,32 @@ Build instructions
 
 ### Prerequisites
 
-The SDK builds with [Gradle](https://gradle.org/) and should be built against Go 1.8 or newer.
+The SDK should be built against Go 1.8 or newer.
 
 ### Building
- 
+
 To build the SDK without running any tests:
 ```
-go build
+make
 ```
 
 If you wish to clean your working directory between builds, you can clean it by running:
 ```
-go clean
+make clean
 ```
 
-When building the SDK, you may need to download additional dependencies. You can do so by using `go get`.
+To run the linter:
 ```
-go get <DEPENDENCY_PACKAGE_NAME_HERE>
+make lint
 ```
 
-
+If you add any new dependencies to the SDK, use `dep ensure` to ensure that they are copied to `vendor/`.
+
 ### Testing
 
 To build the SDK and run all unit tests:
 ```
-go test
+make test
 ```
+
+By default, the full unit test suite includes live tests of the integrations for Consul, DynamoDB, and Redis. Those tests expect you to have instances of all of those databases running locally. To skip them, set the environment variable `LD_SKIP_DATABASE_TESTS=1` before running the tests.

Gopkg.toml

@@ -29,10 +29,6 @@
   name = "github.com/blang/semver"
   version = "3.5.1"
 
-[[constraint]]
-  branch = "master"
-  name = "github.com/facebookgo/httpcontrol"
-
 [[constraint]]
   name = "github.com/garyburd/redigo"
   version = "1.4.0"

Makefile

@@ -1,7 +1,32 @@
-test: lint
-	go test ./...
 
-lint:
-	golangci-lint run ./...
+GOLANGCI_LINT_VERSION=v1.10.2
 
+ifeq ($(LD_SKIP_DATABASE_TESTS),1)
+DB_TEST_PACKAGES=
+else
+DB_TEST_PACKAGES=./redis ./ldconsul ./lddynamodb
+endif
 
+LINTER=./bin/golangci-lint
+
+.PHONY: build clean test lint
+
+build:
+	go build ./...
+
+clean:
+	go clean
+
+test:
+	@# Note, we need to specify all these packages individually for go test in order to remain 1.8-compatible
+	go test -race -v . ./ldfiledata ./ldfilewatch ./ldhttp ./ldntlm ./utils $(DB_TEST_PACKAGES)
+	@# The proxy tests must be run separately because Go caches the global proxy environment variables. We use
+	@# build tags to isolate these tests from the main test run so that if you do "go test ./..." you won't
+	@# get unexpected errors.
+	for tag in proxytest1 proxytest2; do go test -race -v -tags=$$tag ./proxytest; done
+
+$(LINTER):
+	curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s $(GOLANGCI_LINT_VERSION)
+
+lint: $(LINTER)
+	$(LINTER) run ./...

azure-pipelines.yml

@@ -2,6 +2,9 @@ jobs:
   - job: build
     pool:
       vmImage: 'vs2017-win2016'
+    variables:
+      GOPATH: C:\Users\VssAdministrator\go
+      PACKAGE_PATH: gopkg.in\launchdarkly\go-server-sdk.v4
     steps:
       - task: PowerShell@2
         displayName: 'Move Source'
@@ -11,8 +14,8 @@ jobs:
           script: |
             go version
             go env GOPATH
-            mkdir C:\Users\VssAdministrator\go\src\gopkg.in\launchdarkly\go-client.v4
-            mv * C:\Users\VssAdministrator\go\src\gopkg.in\launchdarkly\go-client.v4\
+            mkdir $(GOPATH)\src\$(PACKAGE_PATH)
+            mv * $(GOPATH)\src\$(PACKAGE_PATH)\
       - task: PowerShell@2
         displayName: 'Setup Dynamo'
         inputs:
@@ -52,7 +55,6 @@ jobs:
         displayName: 'Setup SDK and Test'
         inputs:
           targetType: inline
-          workingDirectory: C:\Users\VssAdministrator\go\src\gopkg.in\launchdarkly\go-client.v4
+          workingDirectory: $(GOPATH)\src\$(PACKAGE_PATH)
           script: |
-            go get -t
-            go test -race
+            go test -race ./...