Skip to content

chore: Add explicit permissions for ldotel ci #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Conversation

keelerm84
Copy link
Member

Potential fix for https://github.com/launchdarkly/go-server-sdk/security/code-scanning/16

To fix the issue, we need to add a permissions block to the workflow. This block should specify the least privileges required for the workflow to function correctly. Since the workflow performs basic CI tasks (unit tests, linting, and coverage checks), it likely only requires contents: read permissions.

The permissions block can be added at the root level of the workflow to apply to all jobs, or it can be added to individual jobs if different jobs require different permissions. In this case, adding it at the root level is sufficient and simplifies the configuration.


Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@keelerm84 keelerm84 changed the title Potential fix for code scanning alert no. 16: Workflow does not contain permissions chore: Add explicit permissions for ldotel ci Jun 3, 2025
@keelerm84 keelerm84 marked this pull request as ready for review June 3, 2025 15:33
@keelerm84 keelerm84 requested a review from a team as a code owner June 3, 2025 15:33
@keelerm84 keelerm84 merged commit 539666d into v7 Jun 3, 2025
19 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1297/otel-ci branch June 3, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants