prepare 2.5.1 release #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement Value type for arbitrary JSON values
# Conflicts: # .ldrelease/config.yml
…to v2 # Conflicts: # .circleci/config.yml # CONTRIBUTING.md # README.md
* OptionalString improvements + misc fixes * add OrElse * add tests * comment
This adds an attribute inExperiment to reasons of kinds FALLTHROUGH and RULE_MATCH, as specified in the Experiment Traffic Allocation spec. This attribute is intended to indicate whether the user was targeted by an experiment rollout, and if so, whether they were allocated to one of the experiment variations. We currently plan to use this for two things: * to allow event consumers (currently, the experimentation pipeline and Data Export customers) to filter feature events to only those from users who are part of an experiment. * to allow some SDKs, which use reasons to determine whether to send full events, to avoid sending feature events in the first place after evaluating experiment rollouts for users who are not part of the experiment. (It might seem like this makes the filtering requirement redundant, since there's no need to filter out events that the SDKs declined to send in the first place, but for Data Export customers we want to send all of the events but still filter them for experiment analysis.)
update go-jsonstream version for ch110425 bugfix
# Conflicts: # ldreason/reason.go # ldreason/reason_test.go
* update to newer Releaser config format, add Go 1.16 CI * run code coverage job in Go 1.15
…udit-for-sdk-related-repos-pt-2 Updates docs URLs
add CI job for Go 1.17; update linter & test coverage script
* add comparative benchmarks for v2 * DRY
…-json transparently convert empty raw JSON value to null
cwaldren-ld
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.5.1] - 2022-06-29
Changed:
ldvalue.Valuewith theldvalue.Raw(json.RawMessage)constructor, and you pass a zero-length or nil value to the constructor, and then encode theValueto JSON withjson.Marshalor an equivalent method, the JSON output will now benull(that is, the literal charactersnullrepresenting a JSON null value). Previously it would have been a zero-length string, which is not valid as the JSON encoding of any value and could cause the SDK to output a malformed JSON document if the document contained such a value.