Skip to content

feat: redis source 1.0 #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023
Merged

feat: redis source 1.0 #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ jobs:
os: [ ubuntu-latest, windows-2022, macos-12 ]
runs-on: ${{ matrix.os }}
needs: [ 'release-please' ]
if: ${{ needs.release-please.outputs.package-server-released }}
if: ${{ needs.release-please.outputs.package-server-redis-released }}
outputs:
hashes-linux: ${{ steps.release-server.outputs.hashes-linux }}
hashes-windows: ${{ steps.release-server.outputs.hashes-windows }}
hashes-macos: ${{ steps.release-server.outputs.hashes-macos }}
hashes-linux: ${{ steps.release-server-redis.outputs.hashes-linux }}
hashes-windows: ${{ steps.release-server-redis.outputs.hashes-windows }}
hashes-macos: ${{ steps.release-server-redis.outputs.hashes-macos }}
steps:
- uses: actions/checkout@v3
- id: release-server-redis
Expand Down
3 changes: 2 additions & 1 deletion ...ver-sdk-redis-source/include/launchdarkly/server_side/integrations/redis/redis_source.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ class RedisDataSource final : public ISerializedDataReader {
RedisDataSource(std::unique_ptr<sw::redis::Redis> redis,
std::string prefix);

std::string key_for_kind(ISerializedItemKind const& kind) const;
[[nodiscard]] std::string key_for_kind(
ISerializedItemKind const& kind) const;

std::string const prefix_;
std::string const inited_key_;
Expand Down
4 changes: 1 addition & 3 deletions release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
"extra-files": [
"CMakeLists.txt"
],
"prerelease": true,
"release-as": "0.1.0",
"bump-minor-pre-major": true
"release-as": "1.0.0"
},
"libs/server-sent-events": {
"initial-version": "0.1.0"
Expand Down