Skip to content

Conversation

cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented Jun 1, 2023

Adds a link to the Github releases page, with a search query for the client package.

@cwaldren-ld cwaldren-ld requested a review from kinyoklion June 1, 2023 18:10
@cwaldren-ld cwaldren-ld force-pushed the cw/latest-release-link branch from fb471cd to 38120f6 Compare June 1, 2023 20:49
README.md Outdated
| [libs/client-sdk](libs/client-sdk/README.md) | [C++ Client SDK][package-cpp-client-issues] | [![Actions Status][cpp-client-ci-badge]][cpp-client-ci] | [![Documentation](https://img.shields.io/static/v1?label=GitHub+Pages&message=API+reference&color=00add8)](https://launchdarkly.github.io/cpp-sdks/libs/client-sdk/docs/html/) |
| Readme | issues | tests | docs | latest release |
|----------------------------------------------|---------------------------------------------|---------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------|
| [libs/client-sdk](libs/client-sdk/README.md) | [C++ Client SDK][package-cpp-client-issues] | [![Actions Status][cpp-client-ci-badge]][cpp-client-ci] | [![Documentation](https://img.shields.io/static/v1?label=GitHub+Pages&message=API+reference&color=00add8)](https://launchdarkly.github.io/cpp-sdks/libs/client-sdk/docs/html/) | [On Github](https://github.com/launchdarkly/cpp-sdks/releases?q=launchdarkly-cpp-client) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use this URL instead:
https://github.com/launchdarkly/cpp-sdks/releases?q=%22launchdarkly-cpp-client%22

It will only show the client, without the quotes you also get the SSE client.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL.

Copy link
Member

@kinyoklion kinyoklion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request in a comment.

@cwaldren-ld cwaldren-ld force-pushed the cw/latest-release-link branch from 38120f6 to 1be76e8 Compare June 1, 2023 21:01
@kinyoklion kinyoklion self-requested a review June 1, 2023 21:02
@cwaldren-ld cwaldren-ld merged commit 7cd1bb4 into main Jun 1, 2023
@cwaldren-ld cwaldren-ld deleted the cw/latest-release-link branch June 1, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants