feat: Add c bindings for FlagNotifier. #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #204435: C bindings for flag notifier. |
kinyoklion
commented
May 26, 2023
|
|
||
| // This test registers a listener. It doesn't use the listener, but it | ||
| // will at least ensure 1.) Compilation, and 2.) Allow sanitizers to run. | ||
| TEST(ClientBindings, RegisterFlagListener) { |
There was a problem hiding this comment.
When we do TestData for the server possibly we can add something similar to the client. It would make legitimate testing of these much simpler.
On the C++ side it is better tested because we can directly make the updater.
There was a problem hiding this comment.
I did test this a number of ways in the hello-c app.
kinyoklion
commented
May 26, 2023
| #pragma once | ||
|
|
||
| namespace launchdarkly::client_side { | ||
| namespace launchdarkly { |
There was a problem hiding this comment.
This was moved to common, but client_side was not removed.
cwaldren-ld
reviewed
May 30, 2023
| LD_ASSERT_NOT_NULL(sdk); | ||
| LD_ASSERT_NOT_NULL(flag_key); | ||
|
|
||
| auto connection = TO_SDK(sdk)->FlagNotifier().OnFlagChange( |
There was a problem hiding this comment.
If listener.FlagChanged is null, then is there any need to register a callback?
There was a problem hiding this comment.
I guess we could re-word the documentation to indicate that the returned connection can be NULL if no listener is registered.
Currently the need to register a listener is just to get the connection.
cwaldren-ld
approved these changes
May 30, 2023
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
May 31, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-client-v0.1.0...launchdarkly-cpp-client-v0.2.0) (2023-05-31) ### Features * add AllFlags C binding ([#128](#128)) ([9aa0794](9aa0794)) * Add C bindings for data source status. ([#124](#124)) ([d175abb](d175abb)) * Add c bindings for FlagNotifier. ([#119](#119)) ([11a7f61](11a7f61)) * add Version method to obtain SDK version ([#122](#122)) ([1003117](1003117)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.1.0 to 0.1.1 * launchdarkly-cpp-common bumped from 0.1.0 to 0.2.0 </details> <details><summary>launchdarkly-cpp-common: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-common-v0.1.0...launchdarkly-cpp-common-v0.2.0) (2023-05-31) ### Features * add AllFlags C binding ([#128](#128)) ([9aa0794](9aa0794)) * Add C bindings for data source status. ([#124](#124)) ([d175abb](d175abb)) * Add c bindings for FlagNotifier. ([#119](#119)) ([11a7f61](11a7f61)) * Allow for easier creation of contexts from existing contexts. ([#130](#130)) ([5e18616](5e18616)) ### Bug Fixes * rename C iterator bindings to follow new/free pattern ([#129](#129)) ([24dff9a](24dff9a)) </details> <details><summary>launchdarkly-cpp-internal: 0.1.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-common bumped from 0.1.0 to 0.2.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced May 31, 2023
Merged
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.