prepare 2.4.4 release

.ldrelease/build.ps1

@@ -18,7 +18,12 @@ SetupVSToolsEnv -architecture amd64
 If(Test-Path "curl-7.59.0") {
     Write-Host "Curl already present."
 } Else {
-    DownloadAndUnzip -url "https://curl.haxx.se/download/curl-7.59.0.zip" -filename "curl.zip"
+    # NOTE: Recompute this SHA256 hash whenever the file is updated. This way we can detect
+    # if the file has changed.
+    $CurlSHA256 = "687b77fe00bc6f9dad5623742183028541b4d2c0f64bfd7e0acf7038fda27cdc"
+    $CurlURL = "https://curl.haxx.se/download/curl-7.59.0.zip"
+
+    DownloadAndUnzip -url $CurlURL -filename "curl.zip" -sha256 $CurlSHA256
 
     Write-Host
     Write-Host Building curl
@@ -31,7 +36,12 @@ If(Test-Path "curl-7.59.0") {
 If(Test-Path "pcre-8.43") {
     Write-Host "PRCE already present."
 } Else {
-    DownloadAndUnzip -url "https://ftp.pcre.org/pub/pcre/pcre-8.43.zip" -filename "pcre.zip"
+    # NOTE: Recompute this SHA256 hash whenever the file is updated. This way we can detect
+    # if the file has changed.
+    $PcreSHA256 = "ae236dc25d7e0e738a94e103218e0085eb02ff9bd98f637b6e061a48decdb433"
+    $PcreURL = "https://iweb.dl.sourceforge.net/project/pcre/pcre/8.43/pcre-8.43.zip"
+
+    DownloadAndUnzip -url $PcreURL -filename "pcre.zip" -sha256 $PcreSHA256
 
     Write-Host
     Write-Host Building PCRE

.ldrelease/helpers.psm1

@@ -25,10 +25,18 @@ function ExecuteOrFail {
 function DownloadAndUnzip {
     param(
         [Parameter(Mandatory)][string]$url,
-        [Parameter(Mandatory)][string]$filename
+        [Parameter(Mandatory)][string]$filename,
+        [Parameter(Mandatory)][string]$sha256
     )
     Write-Host Downloading and expanding $url
     ExecuteOrFail { iwr -outf $filename $url }
+    $Hash = Get-FileHash $filename -Algorithm SHA256
+    if ($Hash.Hash -eq $sha256) {
+        Write-Host "SHA256($filename) = ($($Hash.Hash)) OK"
+    } else {
+        Write-Host "SHA256($filename) = ($($Hash.Hash)) MISMATCH"
+        throw "$filename checksum mismatch"
+    }
     ExecuteOrFail { unzip $filename | Out-Null }
 }
 

CONTRIBUTING.md

@@ -27,7 +27,7 @@ cd curl-7.59.0/winbuild
 nmake /f Makefile.vc mode=static
 ```
 
-You can obtain the `libpcre` dependency at [ftp.pcre.org](https://ftp.pcre.org/pub/pcre/pcre-8.43.zip). Extract this archive into the SDK source directory. To build `libpcre` run:
+You can obtain the `libpcre` dependency at [sourceforge.net](https://iweb.dl.sourceforge.net/project/pcre/pcre/8.43/pcre-8.43.zip). Extract this archive into the SDK source directory. To build `libpcre` run:
 
 ```bash
 cd pcre-8.43

include/launchdarkly/client.h

@@ -73,7 +73,7 @@ LDClientTrack(
  * transferred. May not be `NULL`.
  * @param[in] data The JSON to attach to the event. Ownership of `data` is
  * transferred. May be `NULL`.
- * @param[in] metric A metric to be assocated with the event.
+ * @param[in] metric A metric to be associated with the event.
  * @return True if the event was queued, False on error.
  */
 LD_EXPORT(LDBoolean)

include/launchdarkly/store.h

@@ -1,6 +1,6 @@
 /*!
  * @file store.h
- * @brief Public API Interface for Store implementatons
+ * @brief Public API Interface for Store implementations
  */
 
 #pragma once
@@ -47,7 +47,7 @@ struct LDStoreCollectionState
  *
  * The associated functions use a boolean result to indicate success, or error
  * outside of expected functionality. For example a memory allocation error
- * would return false, but `get` on a non existant item would return true.
+ * would return false, but `get` on a non existent item would return true.
  * @{
  ******************************************************************************/
 
@@ -125,7 +125,7 @@ struct LDStoreInterface
      * @brief Determine if the store is initialized with features yet.
      * @param[in] context Implementation specific context.
      * May not be NULL (assert).
-     * @return True if the store is intialized, false otherwise.
+     * @return True if the store is initialized, false otherwise.
      */
     LDBoolean (*initialized)(void *const context);
     /**

include/launchdarkly/variations.h

@@ -11,7 +11,7 @@
 #include <launchdarkly/json.h>
 #include <launchdarkly/user.h>
 
-/** @brief The reason an evaluation occured */
+/** @brief The reason an evaluation occurred */
 enum LDEvalReason
 {
     /** @brief A default unset reason */
@@ -95,7 +95,7 @@ struct LDDetails
     /** @brief True if there is a `variationIndex`, false if the default
      * value was returned. */
     LDBoolean hasVariation;
-    /** @brief The reason an evaluation occured */
+    /** @brief The reason an evaluation occurred */
     enum LDEvalReason reason;
     /** @brief Extra information depending on the evaluation reason */
     union {
@@ -228,7 +228,7 @@ LDStringVariation(
  * If `NULL` no explanation will be generated.
  * @return The fallback will be returned on any error but may be `NULL` on
  * allocation failure.
- * The result must be cleanud up with `LDJSONFree`.
+ * The result must be cleaned up with `LDJSONFree`.
  */
 LD_EXPORT(struct LDJSON *)
 LDJSONVariation(

src/client.c

@@ -1,4 +1,3 @@
-#include <stdlib.h>
 #include <string.h>
 
 #include <launchdarkly/api.h>

src/config.c

@@ -1,4 +1,3 @@
-#include <stdlib.h>
 #include <string.h>
 
 #include <launchdarkly/api.h>

src/evaluate.c

@@ -269,7 +269,7 @@ LDi_evaluate(
                     o_events,
                     recordReason)))
         {
-            LD_LOG(LD_LOG_ERROR, "checkPrequisites failed");
+            LD_LOG(LD_LOG_ERROR, "checkPrerequisites failed");
 
             return substatus;
         }

src/event_processor.c

@@ -1,5 +1,3 @@
-#include <string.h>
-
 #include <launchdarkly/memory.h>
 
 #include "assertion.h"
@@ -522,7 +520,7 @@ LDi_possiblyQueueEvent(
         event = NULL;
     }
 
-    /* consume if neither debug or track */
+    /* consume if neither debug nor track */
     LDJSONFree(event);
 }
 
@@ -1544,7 +1542,7 @@ LDi_bundleEventPayload(
     {
         LDi_mutex_unlock(&context->lock);
 
-        /* succesful but no events to send */
+        /* successful but no events to send */
 
         return LDBooleanTrue;
     }

src/events.c

@@ -9,7 +9,6 @@
 #include "client.h"
 #include "config.h"
 #include "events.h"
-#include "lru.h"
 #include "network.h"
 #include "user.h"
 #include "utility.h"

src/lru.c

@@ -2,7 +2,6 @@
 
 #include "assertion.h"
 #include "lru.h"
-#include "utility.h"
 
 #include "uthash.h"
 #include "utlist.h"

src/network.c

@@ -1,5 +1,4 @@
 #include <curl/curl.h>
-#include <math.h>
 #include <stdio.h>
 
 #include <launchdarkly/api.h>
@@ -318,7 +317,7 @@ LDi_networkthread(void *const clientref)
         }
 
         if (!active_events) {
-            /* if curl is not doing anything wait so we don't burn CPU */
+            /* if curl is not doing anything, wait, so we don't burn CPU */
             LDi_sleepMilliseconds(10);
         }
     }

src/operator.c

@@ -9,7 +9,6 @@
 
 #include "assertion.h"
 #include "operators.h"
-#include "utility.h"
 
 #define CHECKSTRING(uvalue, cvalue)                                            \
     if (LDJSONGetType(uvalue) != LDText || LDJSONGetType(cvalue) != LDText) {  \