Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: launchdarkly/android-client-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5.6.0
Choose a base ref
...
head repository: launchdarkly/android-client-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5.6.1
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Jan 21, 2025

  1. fix: correcting protocol parsing logic that may lead to incorrect san… 

    …itization of an incoming message from LD servers (#288)

After examining related code to a customer support case and #278,
noticed this modification during iteration. Theoretical issue is that
modification during iteration, even if not resulting in
ConcurrentModificationExceptions, could result in unpredictable
iteration and could possibly skip sanitizing certain incoming flags.

Through bench testing and instrumentation testing, I was unable to
reproduce the issue, but I suspect it may be dependent on the specific
platform's implementation of the Map type that GSON will depend on. Will
deploy this fix and work with customers to confirm if the occurrences of
the issue is eliminated.
    @tanderson-ld
    tanderson-ld authored Jan 21, 2025
    Configuration menu
    Copy the full SHA
    9969148 View commit details
    Browse the repository at this point in the history

  2. chore(main): release 5.6.1 (#289) 

    🤖 I have created a release *beep* *boop*
---


##
[5.6.1](5.6.0...5.6.1)
(2025-01-21)


### Bug Fixes

* correcting protocol parsing logic that may lead to incorrect
sanitization of an incoming message from LD servers
([#288](#288))
([9969148](9969148))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] authored Jan 21, 2025
    Configuration menu
    Copy the full SHA
    2a902c8 View commit details
    Browse the repository at this point in the history
Loading