Skip to content

Add the support for the last drivers of Raspberry Pi 3 Model B Plus Rev 1.3 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add the support for the last drivers of Raspberry Pi 3 Model B Plus Rev 1.3 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a165894
support stream camera for Raspberry Pi 3 Model B Plus Rev 1.3
geoffreyp Nov 14, 2020
ff11063
Support still camera for Raspberry Pi 3 Model B Plus Rev 1.3
geoffreyp Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/still-camera.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export default class StillCamera {
case 'BCM2711':
case 'BCM2835 - Pi 3 Model B':
case 'BCM2835 - Pi 3 Model B+':
case 'Raspberry Pi 3 Model B Plus Rev 1.3':
Copy link
Contributor

@gregnr gregnr Nov 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does model really come back with this string on a rev 1.3? Just seems odd that the naming convention would change just for a Pi 3 rev 1.3.

Copy link
Author

@geoffreyp geoffreyp Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gregnr !
Yes it is the correct string, I just use the name throw by the error
``Could not determine JPEG signature. Unknown system model '${systemInfo.model}'
and it works for me

case 'BCM2835 - Pi 4 Model B':
case 'BCM2835 - Pi Zero':
case 'BCM2835 - Pi Zero W':
Expand Down
1 change: 1 addition & 0 deletions src/lib/stream-camera.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ class StreamCamera extends EventEmitter {
case 'BCM2711':
case 'BCM2835 - Pi 3 Model B':
case 'BCM2835 - Pi 3 Model B+':
case 'Raspberry Pi 3 Model B Plus Rev 1.3':
case 'BCM2835 - Pi 4 Model B':
case 'BCM2835 - Pi Zero':
case 'BCM2835 - Pi Zero W':
Expand Down