Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sqlx-sqlite/src/any.rs
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,5 @@ fn map_arguments(args: AnyArguments) -> SqliteArguments {
}

fn map_result(res: SqliteQueryResult) -> AnyQueryResult {
AnyQueryResult {
rows_affected: res.rows_affected(),
last_insert_id: None,
}
AnyQueryResult::from(res)
}
39 changes: 39 additions & 0 deletions tests/sqlite/any.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,45 @@
use sqlx::Any;
use sqlx_test::new;

// Regression test for https://github.com/launchbadge/sqlx/issues/2982
// `map_result()` in sqlx-sqlite/src/any.rs was discarding `last_insert_rowid`,
// always returning `last_insert_id: None` in `AnyQueryResult`.
#[sqlx_macros::test]
async fn any_query_result_has_last_insert_id() -> anyhow::Result<()> {
sqlx::any::install_default_drivers();
let mut conn = new::<Any>().await?;

sqlx::query(
"CREATE TEMPORARY TABLE any_last_id_test (id INTEGER PRIMARY KEY AUTOINCREMENT, name TEXT NOT NULL)",
)
.execute(&mut conn)
.await?;

let result = sqlx::query("INSERT INTO any_last_id_test (name) VALUES (?)")
.bind("Alice")
.execute(&mut conn)
.await?;

assert_eq!(
result.last_insert_id(),
Some(1),
"first insert should return id 1"
);

let result = sqlx::query("INSERT INTO any_last_id_test (name) VALUES (?)")
.bind("Bob")
.execute(&mut conn)
.await?;

assert_eq!(
result.last_insert_id(),
Some(2),
"second insert should return id 2"
);

Ok(())
}

#[sqlx_macros::test]
async fn it_encodes_bool_with_any() -> anyhow::Result<()> {
sqlx::any::install_default_drivers();
Expand Down
Loading