-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: create sqlx.toml format
#3383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b7fdba to
46dd260
Compare
fd557ad to
6c886f8
Compare
This was referenced Aug 2, 2024
Merged
This was referenced Aug 31, 2024
af39902 to
b67a83b
Compare
496f631 to
6cc3ac0
Compare
6cc3ac0 to
3e812b6
Compare
Normally I generate these when cutting the release, but I wanted to take time to editorialize this one.
This was referenced Jul 1, 2025
This was referenced Aug 9, 2025
Closed
|
Although this seems to work great with macros and the cli, it fails with tests in which |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
sqlx.toml: https://github.com/launchbadge/sqlx/blob/sqlx-toml/sqlx-core/src/config/reference.tomlOnce this is implemented, I'm planning on starting an alpha release cycle for 0.9.0 so that we can test this. It's not expected to be a breaking change but it's a large enough feature that it should probably go in a new major release, and there's a few other breaking API changes waiting in the wings.
The keys listed here are just the ones I've identified as needed for an MVP. Other keys may be added later backwards-compatibly.
Breaking Changes
Migratetraitsqlx::migrate::resolve_blocking()is now#[doc(hidden)]and thus SemVer-exemptBikeshedding checklist:
snake_caseorkebab-casefor keys?macros.column_overridesshould maybe be calledmacros.table_overridesinstead?Implementation checklist
[common]database-url-varsqlx-cli[macros]preferred-cratesdate-timenumerictable-overridestype-overrides[migrate]create-schemasmigrate!()sqlx-cliexamples/postgres/multi-tenant)table-namemigrate!()sqlx-cliexamples/postgres/multi-tenant)migrations-dirmigrate!()#[sqlx::test]?sqlx-cliexamples/postgres/multi-tenant)ignored-charsmigrate!()sqlx-clidefaultsmigration-typemigration-versioningcloses #121
closes #3412