fix:the json-feature should activate sqlx-postgres?/json as well
#3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
Jul 16, 2024
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
abonander
approved these changes
Jul 16, 2024
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
…aunchbadge#3350) * fix: made sure that the json feature is defined for postgres as well * fixed the feature order Co-authored-by: Austin Bonander <austin.bonander@gmail.com> --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
…aunchbadge#3350) * fix: made sure that the json feature is defined for postgres as well * fixed the feature order Co-authored-by: Austin Bonander <austin.bonander@gmail.com> --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed (or more accurately missed by me), the
jsonfeature should also activate the postgres' relatedjsonfeature.(I thought that you might like this as a PR as this is simpler for you to accept. If you want your commit in your name, that is fine too ^^)
Does your PR solve an issue?
Fixes #3316