feat: support NonZero* scalar types
#3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
May 30, 2024
abonander
requested changes
May 30, 2024
|
I implemented everything you suggested! Anything else missing? |
|
Since #3126 was merged, you'll need to rebase and fix the compilation errors. |
This commits adds `Type`, `Encode`, and `Decode` impls for all the `NonZero*` types from the standard library. They are implemented as direct proxies to their primitive counterparts, except that when decoding, the values are checked to not be zero.
jayy-lmao
pushed a commit
to jayy-lmao/sqlx
that referenced
this pull request
Jun 6, 2024
* feat: support `NonZero*` scalar types This commits adds `Type`, `Encode`, and `Decode` impls for all the `NonZero*` types from the standard library. They are implemented as direct proxies to their primitive counterparts, except that when decoding, the values are checked to not be zero. * fixup!: remove `non-zero` cargo feature * fixup!: make `non-zero` module private * fixup!: rebase and fix trait impls
|
@AlphaKeks @abonander hi! I used Why? Is it a bug? Should I create a new issue for this? |
|
You need to tell it to use |
|
Thank you! |
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
* feat: support `NonZero*` scalar types This commits adds `Type`, `Encode`, and `Decode` impls for all the `NonZero*` types from the standard library. They are implemented as direct proxies to their primitive counterparts, except that when decoding, the values are checked to not be zero. * fixup!: remove `non-zero` cargo feature * fixup!: make `non-zero` module private * fixup!: rebase and fix trait impls
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
* feat: support `NonZero*` scalar types This commits adds `Type`, `Encode`, and `Decode` impls for all the `NonZero*` types from the standard library. They are implemented as direct proxies to their primitive counterparts, except that when decoding, the values are checked to not be zero. * fixup!: remove `non-zero` cargo feature * fixup!: make `non-zero` module private * fixup!: rebase and fix trait impls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds
Type,Encode, andDecodeimpls for all theNonZero*types from the standard library. They are implemented as direct proxies to their primitive counterparts, except that when decoding, the values are checked to not be zero.fixes #1926