Better io error message for migrate macro #2899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
Dec 31, 2023
| match migrate::expand_migrator_from_lit_dir(input) { | ||
| Ok(ts) => ts.into(), | ||
| Err(e) => { | ||
| if let Some(parse_err) = e.downcast_ref::<syn::Error>() { | ||
| parse_err.to_compile_error().into() | ||
| } else if let Some(io_err) = e.downcast_ref::<std::io::Error>() { | ||
| let msg = format!("Migrations folder not found at '{path}'. Check if the folder exists.\nError: '{io_err}'"); |
There was a problem hiding this comment.
It's not correct to assume that "not found" is the only possible I/O error here. This message would be rather misleading in any other case.
You should at least check the error kind: https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.NotFound
|
@Vrajs16 are you planning on coming back to this? |
|
Closing due to inactivity. I'm working on a better version of this in #3098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1660