Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting client certificate and key from bytes #2646

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Support for setting client certificate and key from bytes #2646

merged 5 commits into from
Sep 26, 2023

Conversation

wyhaya
Copy link
Contributor

@wyhaya wyhaya commented Jul 24, 2023

This PR adds ssl_client_cert_from_bytes and ssl_client_key_from_bytes to MySQL and PostgreSQL.

This will allow slqx to configure tls cert without going through the filesystem. This can be useful in certain scenarios, such as reading certificates from Keychain.

Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wyhaya wyhaya requested a review from abonander August 1, 2023 03:39
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation and examples could be clearer.

sqlx-mysql/src/options/mod.rs Outdated Show resolved Hide resolved
sqlx-mysql/src/options/mod.rs Outdated Show resolved Hide resolved
sqlx-postgres/src/options/mod.rs Outdated Show resolved Hide resolved
sqlx-postgres/src/options/mod.rs Outdated Show resolved Hide resolved
sqlx-mysql/src/options/mod.rs Outdated Show resolved Hide resolved
sqlx-mysql/src/options/mod.rs Outdated Show resolved Hide resolved
sqlx-postgres/src/options/mod.rs Outdated Show resolved Hide resolved
sqlx-postgres/src/options/mod.rs Outdated Show resolved Hide resolved
@abonander
Copy link
Collaborator

abonander commented Sep 26, 2023

Ugh, every time I try to commit suggestions to a PR I end up breaking it more, lol.

I'll fix it.

@abonander abonander merged commit 3b9a274 into launchbadge:main Sep 26, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants