Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set whoami default-features to false #2319

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

thedodd
Copy link
Contributor

@thedodd thedodd commented Jan 24, 2023

Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps.

@thedodd
Copy link
Contributor Author

thedodd commented Jan 24, 2023

Does not look like the CI failures are due to the changes in this PR.

@abonander
Copy link
Collaborator

@thedodd current development is on the 0.7-dev branch which just had some major refactors merged. Do you mind rebasing?

@abonander abonander changed the base branch from main to 0.7-dev February 11, 2023 01:39
@abonander
Copy link
Collaborator

Base changed to 0.7-dev, I forgot to do that if you were waiting for it.

@thedodd thedodd force-pushed the patch-1 branch 2 times, most recently from 9feec26 to a5dbecf Compare February 11, 2023 02:59
cdbfoster and others added 2 commits February 10, 2023 21:00
Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of
additional dependencies. This is really unnecessary, and if
someone has an actual use case where they are attempting to connect
to postgres from a browser, well ... they've probably already been
pwned by now. If it is deemed necessary, then add an additional
activation feature for that specific slew of deps.
dependencies = [
"wasm-bindgen",
"web-sys",
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

@thedodd
Copy link
Contributor Author

thedodd commented Feb 14, 2023

@abonander this should be ready to rock now.

@abonander abonander merged commit fb5215f into launchbadge:0.7-dev Feb 14, 2023
grgi pushed a commit to faccts/sqlx that referenced this pull request Feb 14, 2023
* Fixed typo. (launchbadge#2156)

* Set whoami default-features to false

Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of
additional dependencies. This is really unnecessary, and if
someone has an actual use case where they are attempting to connect
to postgres from a browser, well ... they've probably already been
pwned by now. If it is deemed necessary, then add an additional
activation feature for that specific slew of deps.

---------

Co-authored-by: Chris Foster <cdbfoster@gmail.com>
abonander pushed a commit that referenced this pull request Feb 18, 2023
* Fixed typo. (#2156)

* Set whoami default-features to false

Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of
additional dependencies. This is really unnecessary, and if
someone has an actual use case where they are attempting to connect
to postgres from a browser, well ... they've probably already been
pwned by now. If it is deemed necessary, then add an additional
activation feature for that specific slew of deps.

---------

Co-authored-by: Chris Foster <cdbfoster@gmail.com>
abonander pushed a commit that referenced this pull request Feb 21, 2023
* Fixed typo. (#2156)

* Set whoami default-features to false

Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of
additional dependencies. This is really unnecessary, and if
someone has an actual use case where they are attempting to connect
to postgres from a browser, well ... they've probably already been
pwned by now. If it is deemed necessary, then add an additional
activation feature for that specific slew of deps.

---------

Co-authored-by: Chris Foster <cdbfoster@gmail.com>
@thedodd thedodd deleted the patch-1 branch February 22, 2023 14:58
Aandreba pushed a commit to Aandreba/sqlx that referenced this pull request Mar 31, 2023
* Fixed typo. (launchbadge#2156)

* Set whoami default-features to false

Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of
additional dependencies. This is really unnecessary, and if
someone has an actual use case where they are attempting to connect
to postgres from a browser, well ... they've probably already been
pwned by now. If it is deemed necessary, then add an additional
activation feature for that specific slew of deps.

---------

Co-authored-by: Chris Foster <cdbfoster@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants