Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensures recover from fail with PgCopyIn #2179

Merged

Conversation

andyquinterom
Copy link
Contributor

Fixes #2178

After experimenting for an our or so I fixed my issue by receiving the next notification available when something failed as described in the mentioned issue.

@abonander
Copy link
Collaborator

@andyquinterom current development is on the 0.7-dev branch which just had some major refactors merged. Do you mind rebasing?

@andyquinterom
Copy link
Contributor Author

@abonander Not at all, will work on it this week 😄

@andyquinterom
Copy link
Contributor Author

@abonander Done!

@andyquinterom andyquinterom changed the base branch from main to 0.7-dev February 5, 2023 00:44
@abonander
Copy link
Collaborator

I won't block merging this on it, but if you don't mind doing some follow-up work I'd love to see an integration test for this.

@abonander abonander merged commit 70bc55d into launchbadge:0.7-dev Feb 11, 2023
grgi pushed a commit to faccts/sqlx that referenced this pull request Feb 14, 2023
* CHANGELOG: mention that users should upgrade CLI

* fix: ensures recover from fail with PgCopyIn

---------

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
abonander added a commit that referenced this pull request Feb 18, 2023
* CHANGELOG: mention that users should upgrade CLI

* fix: ensures recover from fail with PgCopyIn

---------

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
abonander added a commit that referenced this pull request Feb 21, 2023
* CHANGELOG: mention that users should upgrade CLI

* fix: ensures recover from fail with PgCopyIn

---------

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Aandreba pushed a commit to Aandreba/sqlx that referenced this pull request Mar 31, 2023
* CHANGELOG: mention that users should upgrade CLI

* fix: ensures recover from fail with PgCopyIn

---------

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sqlx fails to identify the expected message format when copy_in_raw fails
2 participants