Skip empty and commented pgpass entries #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feikesteenbergen
force-pushed
the
skip_empty_pgpass
branch
from
5c70a11
to
a190303
Compare
abonander
requested changes
May 7, 2021
While running an application a lot of warnings were printed about my pgpass file, like: Malformed line in pgpass file This was due to the fact that my pgpass file contains whitespace and comments to organize it in a better way. This commit ensures we will ignore empty lines and lines that (barring whitespace) start with a comment. This is in line with how PostgreSQL treats these entries in the pgpass file: - https://www.postgresql.org/docs/current/libpq-pgpass.html - function passwordFromFile in src/interfaces/libpq/fe-connect.c
feikesteenbergen
force-pushed
the
skip_empty_pgpass
branch
from
a190303
to
18cfd26
Compare
abonander
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running an application a lot of warnings were printed about my
pgpass file, like:
This was due to the fact that my pgpass file contains whitespace and
comments to organize it in a better way.
This commit ensures we will ignore empty lines and lines that (barring
whitespace) start with a comment. This is in line with how PostgreSQL
treats these entries in the pgpass file: