Logging always reports rows: 0 for inserts

[jblachly]

This affects both Postgresql (what I am seeing) as well as Mysql (which you can see from another user's logs in in e.g. #1366 ). It is likely affecting all backends?

An example:

INSERT INTO projects (id, …; rows: 0, elapsed: 4.623ms

Relevant code is here:

sqlx/sqlx-core/src/logger.rs

Lines 54 to 65 in b6e1275

	let rows = self.rows;
	log::logger().log(
	&log::Record::builder()
	.args(format_args!(
	"{}; rows: {}, elapsed: {:.3?}{}",
	summary, rows, elapsed, sql
	))
	.level(lvl)
	.module_path_static(Some("sqlx::query"))
	.target("sqlx::query")
	.build(),

But I am not sure yet how it is called.

Potentially of interest, psql reports the following on insertion:

db_name=*> insert into projects (name, owner_id) values ('Test transaction', '00000000-0000-0000-0000-000000000000');
INSERT 0 1

(i.e. is it possible sqlx reads the leading zero?)

[abonander]

This doesn't seem to be a bug so much as a misunderstanding of the intent here. It appears intentional that QueryLogger::rows is only incremented when a statement returns a result row. It's not necessarily meant to show how many rows were affected, just how many were received back from the database.

We could log a separate field showing the number of rows affected by the statement as reported by the database, but I don't think there's a bug here.

@mehcode wrote this part of the crate so I'd like him to chime in.

cc @david-mcgillicuddy-moixa since this concerns your PR.

[david-mcgillicuddy-moixa]

Ah, I see, that certainly makes that bit of the code make a lot more sense and I never tested with selects, only inserts. I'll update that message to have two fields, "rows returned" and "rows affected".