Skip to content
This repository has been archived by the owner on Dec 29, 2020. It is now read-only.

Commit

Permalink
Merge pull request #12 from laughingman7743/fix_invalid_type_for_regi…
Browse files Browse the repository at this point in the history
…stry_ids

Fix invalid type for registry ids (fix #11)
  • Loading branch information
laughingman7743 authored May 17, 2018
2 parents ad24862 + 6367d9e commit d27f96d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ profile name, region name, registry ID and tag can be set.
+--------------+------------+-------------------------------------------------------------------------------------+
| region_name | str | The region to use. Overrides config/env settings. |
+--------------+------------+-------------------------------------------------------------------------------------+
| registry_id | str | AWS account ID that correspond to a Amazon ECR registry that you want to log in to. |
| registry_id | int | AWS account ID that correspond to a Amazon ECR registry that you want to log in to. |
+--------------+------------+-------------------------------------------------------------------------------------+
| tags | seq of str | Name and optionally a tag in the ‘name:tag’ format. |
+--------------+------------+-------------------------------------------------------------------------------------+
Expand All @@ -77,11 +77,11 @@ Usage
Usage: ecr [OPTIONS] COMMAND [ARGS]...
Options:
--profile TEXT Use a specific profile from your credential file.
--region TEXT The region to use. Overrides config/env settings.
--registry-id TEXT AWS account ID that correspond to a Amazon ECR registry that you want to log in to.
--debug / --no-debug Turn on debug logging.
-h, --help Show this message and exit.
--profile TEXT Use a specific profile from your credential file.
--region TEXT The region to use. Overrides config/env settings.
--registry-id INTEGER AWS account ID that correspond to a Amazon ECR registry that you want to log in to.
--debug / --no-debug Turn on debug logging.
-h, --help Show this message and exit.
Commands:
build Build an image from a Dockerfile.
Expand Down
2 changes: 1 addition & 1 deletion ecr_cli/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
help=msg.HELP_OPTION_PROFILE)
@click.option('--region', type=str, required=False,
help=msg.HELP_OPTION_REGION)
@click.option('--registry-id', type=str, required=False,
@click.option('--registry-id', type=int, required=False,
help=msg.HELP_OPTION_REGISTRY_ID)
@click.option('--debug/--no-debug', required=False, default=False,
help=msg.HELP_OPTION_DEBUG)
Expand Down
2 changes: 1 addition & 1 deletion ecr_cli/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def from_dict(value):
tags,
value.get('profile_name', None),
value.get('region_name', None),
value.get('registry_id', None),)
int(value.get('registry_id', None)),)

def _key(self):
return (self.tags,
Expand Down

0 comments on commit d27f96d

Please sign in to comment.