Change the modules to adhere to the UMD API#6
Open
sorig wants to merge 1 commit intolauerfab:masterfrom
Open
Conversation
|
Hi @sorig, thanks for the work on this issue. Did you manage to actually use the library in Observable? I'd like to try its eigenvalues functions but I'm stuck at https://beta.observablehq.com/d/587aebd683e63fb8 |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple change to the header and footer of the module compilations. The universal module defintion makes MLWeb easily usable from as many environments as possible. Currently the modules assign a global variable which is fine in many cases but may not be compatible with various
requireimplementations (including d3's require implementation used by Observable notebooks)