Skip to content

Conversation

@karooolis
Copy link
Contributor

@karooolis karooolis commented Jul 29, 2025

SQL validation was not getting triggered when using Cmd/Ctrl + Enter. This is because handleSubmit function was registered only once while mounting the Monaco editor at which point the query validation is still not fully initialized. Also, put getLimitOffset in try/catch so it doesn't throw if it gets passed an incorrect query.

CleanShot 2025-07-29 at 20 21 01@2x

@karooolis karooolis requested a review from alvrs as a code owner July 29, 2025 14:05
@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2025

🦋 Changeset detected

Latest commit: 8d4397f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/explorer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/entrykit Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/paymaster Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
vite-plugin-mud Patch
@latticexyz/world-consumer Patch
@latticexyz/world-module-callwithsignature Patch
@latticexyz/world-module-erc20 Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
id.place ❌ Failed (Inspect) Jul 29, 2025 5:26pm

@karooolis karooolis merged commit 6031ec8 into main Aug 26, 2025
20 of 21 checks passed
@karooolis karooolis deleted the kumpis/handle-faulty-query branch August 26, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants