Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(store-consumer): skip dev script #3384

Merged
merged 2 commits into from
Nov 28, 2024
Merged

chore(store-consumer): skip dev script #3384

merged 2 commits into from
Nov 28, 2024

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Nov 28, 2024

there are no typescript files in store-consumer so tsup errors when running dev

@alvrs alvrs requested a review from holic as a code owner November 28, 2024 11:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f2c1981

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs alvrs requested a review from vdrg November 28, 2024 11:10
vdrg
vdrg previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@vdrg vdrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 damn I missed that when copying from erc20 module, lgtm

@vdrg
Copy link
Contributor

vdrg commented Nov 28, 2024

ah actually we can also remove the tsup dependency

@vdrg vdrg self-requested a review November 28, 2024 11:27
@alvrs alvrs merged commit 26e0226 into main Nov 28, 2024
12 checks passed
@alvrs alvrs deleted the store-consumer-dev branch November 28, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdrg vdrg vdrg approved these changes

@holic holic Awaiting requested review from holic holic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvrs @vdrg